YARN-11864. [JDK17] Remove Usage of org.hamcrest in Unit Tests. #7987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
@cnauroth Could you help me review this PR? Thanks a lot! |
|
@szetszwo Could you please review this PR? Thank you very much! |
szetszwo
reviewed
Sep 25, 2025
There was a problem hiding this comment.
+1 the change looks good.
Let's also remove the hamcrest 1.3 dependency? "mvn package" works without it.
diff --git a/hadoop-project/pom.xml b/hadoop-project/pom.xml
index f0086331bd3..d659cf34737 100644
--- a/hadoop-project/pom.xml
+++ b/hadoop-project/pom.xml
@@ -2002,11 +2002,6 @@
<artifactId>snakeyaml</artifactId>
<version>${snakeyaml.version}</version>
</dependency>
- <dependency>
- <groupId>org.hamcrest</groupId>
- <artifactId>hamcrest-library</artifactId>
- <version>1.3</version>
- </dependency>
<dependency>
<groupId>org.assertj</groupId>
<artifactId>assertj-core</artifactId>
diff --git a/hadoop-tools/hadoop-aws/pom.xml b/hadoop-tools/hadoop-aws/pom.xml
index e675c50f241..3a0c0f53cf5 100644
--- a/hadoop-tools/hadoop-aws/pom.xml
+++ b/hadoop-tools/hadoop-aws/pom.xml
@@ -573,11 +573,6 @@
<artifactId>hadoop-minikdc</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.hamcrest</groupId>
- <artifactId>hamcrest-library</artifactId>
- <scope>test</scope>
- </dependency>
<!-- Used to create SSL certs for a secure Keystore -->
<dependency>
<groupId>org.bouncycastle</groupId>
diff --git a/hadoop-tools/hadoop-azure/pom.xml b/hadoop-tools/hadoop-azure/pom.xml
index 58ac82736bd..5ce3a584413 100644
--- a/hadoop-tools/hadoop-azure/pom.xml
+++ b/hadoop-tools/hadoop-azure/pom.xml
@@ -339,11 +339,6 @@
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.hamcrest</groupId>
- <artifactId>hamcrest-library</artifactId>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
diff --git a/hadoop-tools/hadoop-distcp/pom.xml b/hadoop-tools/hadoop-distcp/pom.xml
index 4c1b36d7662..a90713b1e10 100644
--- a/hadoop-tools/hadoop-distcp/pom.xml
+++ b/hadoop-tools/hadoop-distcp/pom.xml
@@ -109,12 +109,6 @@
<artifactId>assertj-core</artifactId>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.hamcrest</groupId>
- <artifactId>hamcrest-library</artifactId>
- <version>1.3</version>
- <scope>test</scope>
- </dependency>
<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter-api</artifactId>
szetszwo
approved these changes
Sep 25, 2025
cnauroth
approved these changes
Sep 25, 2025
|
🎊 +1 overall
This message was automatically generated. |
|
@slfan1989 , thanks for working on this! @cnauroth , thanks for reviewing this! |
@szetszwo @cnauroth Thank you very much for helping to review the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: YARN-11864. [JDK17] Remove Usage of org.hamcrest in Unit Tests.
How was this patch tested?
This pr removes the usage of org.hamcrest in the unit tests. All assertions that previously relied on the Hamcrest library have been refactored to use AssertJ for a more modern, fluent, and readable testing style.
Changes include:
Replaced Hamcrest assertions (assertThat) with AssertJ equivalents.
Removed any imports or references to org.hamcrest in the unit tests.
This update enhances the maintainability and consistency of our test suite by using AssertJ, which is better aligned with our current testing practices.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?