YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager. #7986

slfan1989 · 2025-09-20T01:12:35Z

Description of PR

JIRA: YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager.

During the process of completely removing JUnit4 dependencies, we found that the NoExitSecurityManager class is still used in the project. To further reduce JUnit4 dependencies and maintain code cleanliness, it needs to be removed.

How was this patch tested?

Manual testing.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

hadoop-yetus · 2025-09-20T07:12:31Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	12m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	40m 17s		trunk passed
+1 💚	compile	15m 50s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	13m 31s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	4m 6s		trunk passed
+1 💚	mvnsite	2m 50s		trunk passed
+1 💚	javadoc	2m 21s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 54s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	4m 31s		trunk passed
+1 💚	shadedclient	37m 12s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 45s		the patch passed
+1 💚	compile	15m 5s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 5s		the patch passed
+1 💚	compile	14m 23s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	14m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 5s		the patch passed
+1 💚	mvnsite	2m 52s		the patch passed
+1 💚	javadoc	2m 16s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 53s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	4m 53s		the patch passed
+1 💚	shadedclient	38m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 40s		hadoop-common in the patch passed.
-1 ❌	unit	110m 33s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚	asflicense	1m 4s		The patch does not generate ASF License warnings.
		358m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/1/artifact/out/Dockerfile
GITHUB PR	#7986
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 17694c6f0397 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `afd66a0`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/1/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-09-21T07:27:16Z

I observed a SurefireBooterForkException on Jenkins, with the error focused on TestAppManager (process exited with code 255, likely due to a forked JVM crash or a System.exit call).

I wasn’t able to reproduce this issue locally (mvn -Dtest=org.apache.hadoop.yarn.server.resourcemanager.TestAppManager test, all 45 test cases passed).

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.server.resourcemanager.TestAppManager


[INFO] Tests run: 45, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.13 s -- in org.apache.hadoop.yarn.server.resourcemanager.TestAppManager
[INFO] 
[INFO] Results:
[INFO]

To verify whether this is only triggered by that specific test case in CI, I plan to temporarily disable TestAppManager, check if the overall build and remaining tests are stable, and then circle back to identify the root cause and re-enable the test.

hadoop-yetus · 2025-09-21T13:24:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	9m 56s		Maven dependency ordering for branch
+1 💚	mvninstall	40m 31s		trunk passed
+1 💚	compile	15m 50s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	13m 50s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	4m 18s		trunk passed
+1 💚	mvnsite	3m 0s		trunk passed
+1 💚	javadoc	2m 28s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 1s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	4m 50s		trunk passed
+1 💚	shadedclient	37m 27s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 47s		the patch passed
+1 💚	compile	15m 1s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 1s		the patch passed
+1 💚	compile	13m 50s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	13m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 12s		the patch passed
+1 💚	mvnsite	2m 59s		the patch passed
+1 💚	javadoc	2m 25s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 4s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	5m 3s		the patch passed
+1 💚	shadedclient	36m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 58s		hadoop-common in the patch passed.
-1 ❌	unit	113m 41s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚	asflicense	1m 7s		The patch does not generate ASF License warnings.
		360m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/2/artifact/out/Dockerfile
GITHUB PR	#7986
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 4aa2d17007e5 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f2c111a`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/2/testReport/
Max. process+thread count	3152 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-09-23T05:36:07Z

I observed a SurefireBooterForkException on Jenkins, with the error focused on TestAppManager (process exited with code 255, likely due to a forked JVM crash or a System.exit call).

I wasn’t able to reproduce this issue locally (mvn -Dtest=org.apache.hadoop.yarn.server.resourcemanager.TestAppManager test, all 45 test cases passed).
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.yarn.server.resourcemanager.TestAppManager


[INFO] Tests run: 45, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 22.13 s -- in org.apache.hadoop.yarn.server.resourcemanager.TestAppManager
[INFO] 
[INFO] Results:
[INFO] 
To verify whether this is only triggered by that specific test case in CI, I plan to temporarily disable TestAppManager, check if the overall build and remaining tests are stable, and then circle back to identify the root cause and re-enable the test.

Confirmed that the Maven Surefire thread overflow issue is unrelated to TestAppManager. In the local environment, TestAppManager passes tests successfully; even when TestAppManager is disabled, the thread overflow still occurs in CI.

hadoop-yetus · 2025-09-23T11:36:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 2 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	10m 58s		Maven dependency ordering for branch
+1 💚	mvninstall	40m 17s		trunk passed
+1 💚	compile	15m 55s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	compile	14m 5s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	checkstyle	4m 17s		trunk passed
+1 💚	mvnsite	2m 57s		trunk passed
+1 💚	javadoc	2m 26s		trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 2s		trunk passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	4m 46s		trunk passed
+1 💚	shadedclient	37m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 46s		the patch passed
+1 💚	compile	15m 11s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javac	15m 11s		the patch passed
+1 💚	compile	13m 52s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	javac	13m 52s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	4m 12s		the patch passed
+1 💚	mvnsite	2m 57s		the patch passed
+1 💚	javadoc	2m 19s		the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	2m 2s		the patch passed with JDK Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
+1 💚	spotbugs	5m 5s		the patch passed
+1 💚	shadedclient	36m 45s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	23m 2s		hadoop-common in the patch passed.
-1 ❌	unit	114m 29s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt	hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚	asflicense	1m 3s		The patch does not generate ASF License warnings.
		361m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/3/artifact/out/Dockerfile
GITHUB PR	#7986
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux b4da9a6cb681 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `38b7147`
Default Java	Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-ga~~us1-0ubuntu1~~20.04-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/3/testReport/
Max. process+thread count	1270 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7986/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

zhtttylz

+1,LGTM @slfan1989

steveloughran

+1

slfan1989 · 2025-09-24T01:05:02Z

@steveloughran @zhtttylz Thanks for the review!

YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager.

afd66a0

github-actions bot added YARN trunk Common labels Sep 20, 2025

YARN-11863. Disable TestAppManager.

f2c111a

YARN-11863. Revert Disable TestAppManager.

38b7147

zhtttylz approved these changes Sep 23, 2025

View reviewed changes

steveloughran reviewed Sep 23, 2025

View reviewed changes

slfan1989 merged commit 5f5dc03 into apache:trunk Sep 24, 2025
1 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager. #7986

YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager. #7986

Uh oh!

slfan1989 commented Sep 20, 2025 •

edited

Loading

Uh oh!

hadoop-yetus commented Sep 20, 2025

Uh oh!

slfan1989 commented Sep 21, 2025

Uh oh!

hadoop-yetus commented Sep 21, 2025

Uh oh!

slfan1989 commented Sep 23, 2025

Uh oh!

hadoop-yetus commented Sep 23, 2025

Uh oh!

zhtttylz left a comment

Uh oh!

steveloughran left a comment

Uh oh!

Uh oh!

slfan1989 commented Sep 24, 2025

Uh oh!

Uh oh!

YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager. #7986

YARN-11863. [JDK17] Remove JUnit4 NoExitSecurityManager. #7986

Uh oh!

Conversation

slfan1989 commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Sep 20, 2025

Uh oh!

slfan1989 commented Sep 21, 2025

Uh oh!

hadoop-yetus commented Sep 21, 2025

Uh oh!

slfan1989 commented Sep 23, 2025

Uh oh!

hadoop-yetus commented Sep 23, 2025

Uh oh!

zhtttylz left a comment

Choose a reason for hiding this comment

Uh oh!

steveloughran left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

slfan1989 commented Sep 24, 2025

Uh oh!

Uh oh!

slfan1989 commented Sep 20, 2025 •

edited

Loading