-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19692. Exclude junit 4 transitive dependency. #7978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 pending pre-commit. I wonder if we will see that some of these test frameworks still need JUnit 4 internally though. Pre-submit should tell us.
💔 -1 overall
This message was automatically generated. |
It turns out that we have not completely removed junit tests.
|
The reason is that |
💔 -1 overall
This message was automatically generated. |
The test failure is not easy to fix:
The junit 4 Assert is in Will revert the change and fix it separately. |
🎊 +1 overall
This message was automatically generated. |
Probably not -- the current code in LuceneTestCase still says, "Base class for all Lucene unit tests, Junit3 or Junit4 variant." |
Filed HADOOP-19699 for TestAppCatalogSolrClient |
Thanks @cnauroth and @slfan1989 for reviewing this! |
@szetszwo Thank you for the contribution! |
Description of PR
HADOOP-19692
The direct junit 4 dependency was removed by HADOOP-19617. However, junit 4 is still pulled transitively by other dependencies.
How was this patch tested?
By the pull request action.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?