Skip to content

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Mar 10, 2025

Description of PR

HADOOP-19489. Remove broken Centos 7 C++ precommit checks from CI.

Remove the Centos 7 C++ precommit check from CI.

How was this patch tested?

It wasn't, I am not able test Jenkins changes locally.

For code changes:

  • [X ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@stoty stoty changed the title HADOOP-19489, Remove broken Centos 7 C++ precommit checks from CI HADOOP-19489. Remove broken Centos 7 C++ precommit checks from CI Mar 10, 2025
@pan3793
Copy link
Member

pan3793 commented Mar 10, 2025

This sounds like a silent breaking change. I know CentOS 7 has been sunset, but ... we have dozens of thousands of Hadoop nodes running on CentOS 7 as of today ...

Please at least discuss the drop support of CentOS 7 in the mailing list ...

@stoty
Copy link
Contributor Author

stoty commented Mar 10, 2025

I have started a discussion on dev@hadoop.apache.org , @pan3793 .

@slfan1989
Copy link
Contributor

I have started a discussion on dev@hadoop.apache.org , @pan3793 .

@stoty Thank you for raising this issue! I believe the email should also be CC'd to the common-dev(common-dev@hadoop.apache.org). Regarding CentOS 7, we do need to discuss a clear EOL date. Currently, many projects have switched to CentOS 8 as their base image (though it's not a very new image). From my understanding, our releases are currently based on ubuntu:focal, and there haven't been any issues with that image so far.

cc: @ayushtkn @steveloughran @Hexiaoqiao @cnauroth

@stoty
Copy link
Contributor Author

stoty commented Mar 11, 2025

Oops. I managed to spam the wrong list yesterday.
Sent the mail to dev@hadoop.apache.org and separately cc-d to dev-common@hadoop.apache.org.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+0 🆗 mvndep 5m 47s Maven dependency ordering for branch
+1 💚 shadedclient 21m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 shadedclient 19m 54s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
49m 35s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7493/1/artifact/out/Dockerfile
GITHUB PR #7493
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs
uname Linux 4a7e106988e1 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / ec93d81
Max. process+thread count 553 (vs. ulimit of 5500)
modules C: U:
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7493/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pan3793
Copy link
Member

pan3793 commented Jul 23, 2025

Given that most people do not consider EOL OS support as part of the Hadoop compatibility commitment, I think we should merge this (both into trunk and branch-3.4) to make the CI happy. (I can make follow-up changes to clean up the Dockerfile and other EOL OS stuff)

https://lists.apache.org/thread/2ypqcrnsth3jk21rpjvjv53tntz21ht8
https://lists.apache.org/thread/yj5lx4lmrflyqyfvwmjt74y3jcl65tk0
#7790 (comment)

@ayushtkn @cnauroth can any of you help merging this?

@slfan1989
Copy link
Contributor

slfan1989 commented Jul 23, 2025

@pan3793 Thank you very much for the clarification! However, I will continue to follow up on the adjustments related to the build script. As for this PR, I believe that if we intend to completely remove all EOL operating systems, it would be more appropriate to carry out the full removal within this same PR (#7822) .

Copy link
Contributor

@cnauroth cnauroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slfan1989 , it sounds like you are proposing that #7822 would supersede #7493 . Do I understand correctly? If so, then let's be sure to give @stoty a Co-authored-by tag for credit in the commit.

@slfan1989
Copy link
Contributor

@slfan1989 , it sounds like you are proposing that #7822 would supersede #7493 . Do I understand correctly? If so, then let's be sure to give @stoty a Co-authored-by tag for credit in the commit.

@cnauroth Thank you for your message! I resubmitted #7822 because I hope to remove the support for EOL operating systems in one go. If we submit multiple PRs, it might result in repetitive work, so removing it all at once would be more efficient and convenient.

cc: @stoty @pan3793

@chenyuan99
Copy link

since #7822 is already merged, I think we can close this PR @stoty

@stoty
Copy link
Contributor Author

stoty commented Sep 18, 2025

Thanks, sure.

@stoty stoty closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants