-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19489. Remove broken Centos 7 C++ precommit checks from CI #7493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This sounds like a silent breaking change. I know CentOS 7 has been sunset, but ... we have dozens of thousands of Hadoop nodes running on CentOS 7 as of today ... Please at least discuss the drop support of CentOS 7 in the mailing list ... |
I have started a discussion on dev@hadoop.apache.org , @pan3793 . |
@stoty Thank you for raising this issue! I believe the email should also be CC'd to the common-dev(common-dev@hadoop.apache.org). Regarding CentOS 7, we do need to discuss a clear EOL date. Currently, many projects have switched to CentOS 8 as their base image (though it's not a very new image). From my understanding, our releases are currently based on ubuntu:focal, and there haven't been any issues with that image so far. |
Oops. I managed to spam the wrong list yesterday. |
🎊 +1 overall
This message was automatically generated. |
Given that most people do not consider EOL OS support as part of the Hadoop compatibility commitment, I think we should merge this (both into trunk and branch-3.4) to make the CI happy. (I can make follow-up changes to clean up the Dockerfile and other EOL OS stuff) https://lists.apache.org/thread/2ypqcrnsth3jk21rpjvjv53tntz21ht8 |
@pan3793 Thank you very much for the clarification! However, I will continue to follow up on the adjustments related to the build script. As for this PR, I believe that if we intend to completely remove all EOL operating systems, it would be more appropriate to carry out the full removal within this same PR (#7822) . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slfan1989 , it sounds like you are proposing that #7822 would supersede #7493 . Do I understand correctly? If so, then let's be sure to give @stoty a Co-authored-by tag for credit in the commit.
@cnauroth Thank you for your message! I resubmitted #7822 because I hope to remove the support for EOL operating systems in one go. If we submit multiple PRs, it might result in repetitive work, so removing it all at once would be more efficient and convenient. |
Thanks, sure. |
Description of PR
HADOOP-19489. Remove broken Centos 7 C++ precommit checks from CI.
Remove the Centos 7 C++ precommit check from CI.
How was this patch tested?
It wasn't, I am not able test Jenkins changes locally.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?