-
Notifications
You must be signed in to change notification settings - Fork 9.1k
YARN-11247. Remove unused classes introduced by YARN-9615. #4720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@ayushtkn Can you help review this pr? Thank you very much! |
💔 -1 overall
This message was automatically generated. |
@dineshchitlangia Can you help review this pr? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @slfan1989 , thanks for catching this and fixing it.
@dineshchitlangia Thank you very much for your help reviewing the code! |
JIRA:YARN-11247. Remove unused classes introduced by YARN-9615.
YARN-9615:
adds Metric to RM's dispatcher, but the patch introduces a class without any usage
org.apache.hadoop.yarn.metrics#DisableEventTypeMetrics
I think this class can be removed.