-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-18181. Move prefetch common classes to hadoop common #4690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18181. Move prefetch common classes to hadoop common #4690
Conversation
+ code style changes
|
+moved some other tests to interceptFuture Change-Id: Id36f784e60e47606f6fe32781fb859dbc6635ba7
…tching rename classes to show they are in the s3a codebase and try and make a bit clearer their purposes. Change-Id: I1527a47185b426e3b94237026ece0753a3e7c5ce
c39a1e0
to
2dda979
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is mostly moving packages, renaming and minor refactorings. I am +1 with this change given we have a successful yetus run.
...-project/hadoop-common/src/main/java/org/apache/hadoop/fs/impl/prefetch/BlockOperations.java
Outdated
Show resolved
Hide resolved
Change-Id: Idc7cf29c0ac580e2f697fbcf92f724f60aa35391
Change-Id: Ibcf3f5b829a2d830d46064005e9a2c8c5364bd68
…nums Change-Id: Ifd04bfa100a1bfb9666f7f21dfb658d649beebe8
final bit of big style cleanup; checkstyle and removal of this. prefix when it is not needed. Code cleanup from IDE for ~our style rules Change-Id: I3e4f9682a7e0be29007a517de8890822d267d31a
Change-Id: Ibe68d70fbd4049c2c86e33e826d29729453e08a0
🎊 +1 overall
This message was automatically generated. |
ready for review again @mukund-thakur |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
This moves the "common" classes for the prefetch code from hadoop-aws to hadoop common under org.apache.hadoop.fs.impl.prefetch
How was this patch tested?
s3 london; all good apart from landsat scale test timeout which i am now seeing everywhere
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?