Skip to content

Conversation

steveloughran
Copy link
Contributor

@steveloughran steveloughran commented Aug 3, 2022

This moves the "common" classes for the prefetch code from hadoop-aws to hadoop common under org.apache.hadoop.fs.impl.prefetch

How was this patch tested?

s3 london; all good apart from landsat scale test timeout which i am now seeing everywhere

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran
Copy link
Contributor Author

+moved some other tests to interceptFuture

Change-Id: Id36f784e60e47606f6fe32781fb859dbc6635ba7
…tching

rename classes to show they are in the s3a codebase and try and make a bit
clearer their purposes.

Change-Id: I1527a47185b426e3b94237026ece0753a3e7c5ce
@steveloughran steveloughran force-pushed the s3/HADOOP-18181-rename-classes branch from c39a1e0 to 2dda979 Compare August 4, 2022 10:43
Copy link
Contributor

@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is mostly moving packages, renaming and minor refactorings. I am +1 with this change given we have a successful yetus run.

@apache apache deleted a comment from hadoop-yetus Aug 5, 2022
@apache apache deleted a comment from hadoop-yetus Aug 5, 2022
Change-Id: Idc7cf29c0ac580e2f697fbcf92f724f60aa35391
@apache apache deleted a comment from hadoop-yetus Aug 8, 2022
Change-Id: Ibcf3f5b829a2d830d46064005e9a2c8c5364bd68
…nums

Change-Id: Ifd04bfa100a1bfb9666f7f21dfb658d649beebe8
@apache apache deleted a comment from hadoop-yetus Aug 10, 2022
final bit of big style cleanup; checkstyle and removal of this. prefix
when it is not needed. Code cleanup from IDE for ~our style rules

Change-Id: I3e4f9682a7e0be29007a517de8890822d267d31a
Change-Id: Ibe68d70fbd4049c2c86e33e826d29729453e08a0
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 2s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 43 new or modified test files.
_ feature-HADOOP-18028-s3a-prefetch Compile Tests _
+0 🆗 mvndep 14m 39s Maven dependency ordering for branch
+1 💚 mvninstall 24m 55s feature-HADOOP-18028-s3a-prefetch passed
+1 💚 compile 23m 10s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 compile 20m 37s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 4m 30s feature-HADOOP-18028-s3a-prefetch passed
+1 💚 mvnsite 3m 43s feature-HADOOP-18028-s3a-prefetch passed
+1 💚 javadoc 2m 57s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 2m 40s feature-HADOOP-18028-s3a-prefetch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 5m 2s feature-HADOOP-18028-s3a-prefetch passed
+1 💚 shadedclient 22m 34s branch has no errors when building and testing our client artifacts.
-0 ⚠️ patch 23m 6s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 1m 46s the patch passed
+1 💚 compile 22m 24s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javac 22m 24s the patch passed
+1 💚 compile 20m 48s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 javac 20m 48s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 16s the patch passed
+1 💚 mvnsite 3m 34s the patch passed
+1 💚 javadoc 2m 52s the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚 javadoc 2m 43s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 5m 12s the patch passed
+1 💚 shadedclient 22m 39s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 18m 56s hadoop-common in the patch passed.
+1 💚 unit 3m 27s hadoop-aws in the patch passed.
+1 💚 asflicense 1m 35s The patch does not generate ASF License warnings.
242m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4690/8/artifact/out/Dockerfile
GITHUB PR #4690
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 4fc7f1caf820 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision feature-HADOOP-18028-s3a-prefetch / 21b5318
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4690/8/testReport/
Max. process+thread count 1251 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4690/8/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@apache apache deleted a comment from hadoop-yetus Aug 16, 2022
@apache apache deleted a comment from hadoop-yetus Aug 16, 2022
@steveloughran
Copy link
Contributor Author

ready for review again @mukund-thakur

Copy link
Contributor

@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@steveloughran steveloughran merged commit 36bbde2 into apache:feature-HADOOP-18028-s3a-prefetch Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants