HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages #4674

ZanderXu · 2022-08-02T15:53:25Z

Description of PR

Improve Code with Lambda in org.apahce.hadoop.hdfs.server.namenode sub packages.

For example:
Current logic:

public ListenableFuture<GetJournaledEditsResponseProto> getJournaledEdits(
      long fromTxnId, int maxTransactions) {
    return parallelExecutor.submit(
        new Callable<GetJournaledEditsResponseProto>() {
          @Override
          public GetJournaledEditsResponseProto call() throws IOException {
            return getProxy().getJournaledEdits(journalId, nameServiceId,
                fromTxnId, maxTransactions);
          }
        });
  }

Improved Code with Lambda:

public ListenableFuture<GetJournaledEditsResponseProto> getJournaledEdits(
      long fromTxnId, int maxTransactions) {
    return parallelExecutor.submit(() -> getProxy().getJournaledEdits(
        journalId, nameServiceId, fromTxnId, maxTransactions));
  }

ZanderXu · 2022-08-02T15:54:57Z

@goiri @slfan1989 Sir, this pr is used to improve code with Lambada in org.apache.hadoop.hdfs.server.namenode sub packages. Please help me review, thanks.

slfan1989 · 2022-08-02T22:11:30Z

LGTM +1

hadoop-yetus · 2022-08-03T00:09:01Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 4s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 1s		trunk passed
+1 💚	compile	1m 59s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 42s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 20s		trunk passed
+1 💚	mvnsite	1m 59s		trunk passed
+1 💚	javadoc	1m 32s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 55s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 19s		trunk passed
+1 💚	shadedclient	29m 1s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 34s		the patch passed
+1 💚	compile	1m 41s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 41s		the patch passed
+1 💚	compile	1m 30s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 30s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 9s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 92 unchanged - 11 fixed = 93 total (was 103)
+1 💚	mvnsite	1m 40s		the patch passed
+1 💚	javadoc	1m 8s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 56s		the patch passed
+1 💚	shadedclient	28m 6s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	363m 41s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 58s		The patch does not generate ASF License warnings.
		494m 2s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/1/artifact/out/Dockerfile
GITHUB PR	#4674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 0f5eb6b217ef 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / e24d56e215b8ef5467f26816b2edc79e214f53cb
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/1/testReport/
Max. process+thread count	2151 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-08-03T13:57:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 48s		trunk passed
+1 💚	compile	1m 44s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 33s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 19s		trunk passed
+1 💚	mvnsite	1m 44s		trunk passed
+1 💚	javadoc	1m 21s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 48s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	4m 1s		trunk passed
+1 💚	shadedclient	27m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 32s		the patch passed
+1 💚	compile	1m 38s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 38s		the patch passed
+1 💚	compile	1m 25s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 25s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 3s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 92 unchanged - 11 fixed = 92 total (was 103)
+1 💚	mvnsite	1m 37s		the patch passed
+1 💚	javadoc	1m 0s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 34s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 43s		the patch passed
+1 💚	shadedclient	26m 22s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	341m 22s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 59s		The patch does not generate ASF License warnings.
		462m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/2/artifact/out/Dockerfile
GITHUB PR	#4674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 6d6e90a4dcec 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / d2900a8715cd9bb9032d6255835a25debe1d7546
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/2/testReport/
Max. process+thread count	1924 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ZanderXu · 2022-08-11T12:57:12Z

@goiri Hi, Master, can help me merge this PR into trunk? Thank you very much.

…namenode sub packages

ZanderXu · 2022-08-17T15:07:20Z

@goiri Master, ping, I have rebased this patch base on latest trunk. Can you help me merge it into trunk? I don't want to forget it, so thanks.

hadoop-yetus · 2022-08-17T22:52:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 9s		trunk passed
+1 💚	compile	1m 43s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	1m 33s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	1m 17s		trunk passed
+1 💚	mvnsite	1m 41s		trunk passed
+1 💚	javadoc	1m 21s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 43s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 52s		trunk passed
+1 💚	shadedclient	26m 5s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 24s		the patch passed
+1 💚	compile	1m 31s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	1m 31s		the patch passed
+1 💚	compile	1m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	1m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 1s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 90 unchanged - 11 fixed = 90 total (was 101)
+1 💚	mvnsite	1m 26s		the patch passed
+1 💚	javadoc	0m 59s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	1m 30s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	3m 35s		the patch passed
+1 💚	shadedclient	26m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	346m 39s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 57s		The patch does not generate ASF License warnings.
		465m 30s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.mover.TestMover

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/3/artifact/out/Dockerfile
GITHUB PR	#4674
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 16128a370dd8 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ed87347`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/3/testReport/
Max. process+thread count	2070 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4674/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

goiri approved these changes Aug 2, 2022

View reviewed changes

HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server…

ed87347

…namenode sub packages

ZanderXu force-pushed the HDFS-16713 branch from d2900a8 to ed87347 Compare August 17, 2022 15:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages #4674

HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages #4674

Uh oh!

ZanderXu commented Aug 2, 2022

Uh oh!

ZanderXu commented Aug 2, 2022

Uh oh!

slfan1989 commented Aug 2, 2022

Uh oh!

hadoop-yetus commented Aug 3, 2022

Uh oh!

hadoop-yetus commented Aug 3, 2022

Uh oh!

ZanderXu commented Aug 11, 2022

Uh oh!

ZanderXu commented Aug 17, 2022

Uh oh!

hadoop-yetus commented Aug 17, 2022

Uh oh!

Uh oh!

HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages #4674

Are you sure you want to change the base?

HDFS-16713. Improve code with Lambda in org.apache.hadoop.hdfs.server.namenode sub packages #4674

Uh oh!

Conversation

ZanderXu commented Aug 2, 2022

Description of PR

Uh oh!

ZanderXu commented Aug 2, 2022

Uh oh!

slfan1989 commented Aug 2, 2022

Uh oh!

hadoop-yetus commented Aug 3, 2022

Uh oh!

hadoop-yetus commented Aug 3, 2022

Uh oh!

ZanderXu commented Aug 11, 2022

Uh oh!

ZanderXu commented Aug 17, 2022

Uh oh!

hadoop-yetus commented Aug 17, 2022

Uh oh!

Uh oh!