Skip to content

HDFS-16676. DatanodeAdminManager$Monitor reports a node as invalid continuously #4626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

HDFS-16676. DatanodeAdminManager$Monitor reports a node as invalid continuously #4626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28c374c
HDFS-16676. DatanodeAdminManager$Monitor reports a node as invalid co…
Jul 25, 2022
a3c4dc9
Changing inValidState to isValidState
Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .../main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeAdminDefaultMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ private void check() {
iterkey).iterator();
final List<DatanodeDescriptor> toRemove = new ArrayList<>();
final List<DatanodeDescriptor> unhealthyDns = new ArrayList<>();
boolean isValidState = true;

while (it.hasNext() && !exceededNumBlocksPerCheck() && namesystem
.isRunning()) {
Expand Down Expand Up @@ -265,6 +266,7 @@ private void check() {
// to track maintenance expiration.
dnAdmin.setInMaintenance(dn);
} else {
isValidState = false;
Preconditions.checkState(false,
"Node %s is in an invalid state! "
+ "Invalid state: %s %s blocks are on this dn.",
Expand All @@ -288,7 +290,11 @@ private void check() {
// an invalid state.
LOG.warn("DatanodeAdminMonitor caught exception when processing node "
+ "{}.", dn, e);
getPendingNodes().add(dn);
if(isValidState){
getPendingNodes().add(dn);
} else {
LOG.warn("Ignoring the node {} which is in invalid state", dn);
}
toRemove.add(dn);
unhealthyDns.remove(dn);
} finally {
Expand Down