Skip to content

HADOOP-18362. Solve ZKFailoverController throw ambiguous exception #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

HADOOP-18362. Solve ZKFailoverController throw ambiguous exception #4625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e9370e3
Update ZKFailoverController.java
MEILIDEKCL Jul 25, 2022
4fe152f
Merge pull request #1 from MEILIDEKCL/MEILIDEKCL-patch-1
MEILIDEKCL Jul 25, 2022
8eddcbf
Update ZKFailoverController.java
MEILIDEKCL Jul 26, 2022
f893ae9
Update UserGroupInformation.java
MEILIDEKCL Jul 26, 2022
eb92779
Update UserGroupInformation.java
MEILIDEKCL Jul 26, 2022
2ebab6d
Update UserGroupInformation.java
MEILIDEKCL Jul 27, 2022
eebe175
Update TestUserGroupInformation.java
MEILIDEKCL Jul 27, 2022
31aa4f5
Update UserGroupInformation.java
MEILIDEKCL Jul 27, 2022
133fac4
Update Groups.java
MEILIDEKCL Jul 27, 2022
6dd2e39
Update Groups.java
MEILIDEKCL Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/Groups.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ public Groups(Configuration conf, final Timer timer) {
JniBasedUnixGroupsMappingWithFallback.class,
GroupMappingServiceProvider.class),
conf);

cacheTimeout =
conf.getLong(CommonConfigurationKeys.HADOOP_SECURITY_GROUPS_CACHE_SECS,
CommonConfigurationKeys.HADOOP_SECURITY_GROUPS_CACHE_SECS_DEFAULT) * 1000;
Expand All @@ -131,7 +130,11 @@ public Groups(Configuration conf, final Timer timer) {
CommonConfigurationKeys.
HADOOP_SECURITY_GROUPS_CACHE_BACKGROUND_RELOAD_THREADS_DEFAULT);
parseStaticMapping(conf);

if(cacheTimeout<=0){
throw new IllegalArgumentException(
"hadoop.security.groups.cache.secs should be larger than 0",
new IllegalArgumentException("hadoop.security.groups.cache.secs should be larger than 0"));
}
this.timer = timer;
this.cache = CacheBuilder.newBuilder()
.refreshAfterWrite(cacheTimeout, TimeUnit.MILLISECONDS)
Expand Down
1 change: 1 addition & 0 deletions ...ject/hadoop-common/src/test/java/org/apache/hadoop/security/TestUserGroupInformation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
Expand Down