HDFS-16331. Make dfs.blockreport.intervalMsec reconfigurable #3676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Thses failed tests are unrelated to the change and work fine locally. @aajisaka @jojochuang @tasanuma @goiri PTAL. Thanks a lot. |
|
🎊 +1 overall
This message was automatically generated. |
|
@jojochuang @tasanuma @ferhui @ayushtkn , PTAL. Thanks. |
|
💔 -1 overall
This message was automatically generated. |
|
I'm a little nervous about making |
|
In the following code, |
Thanks @tasanuma for your comments. I will look into this. |
|
💔 -1 overall
This message was automatically generated. |
Hi @tasanuma , I fixed this. PTAL. Thank you very much. In addition, I find that |
|
@tomscut Indeed, we don't indent case statements from a switch statement. Please fix them. And please fix the check style warnings too. |
|
@tomscut Oh, I meant please fix the indents of |
Sorry, I misunderstood. And I will fix this. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed unit tests are unrelated to the change and work fine locally. They failed because of OOM. We might need to take a look at the compile environment? Hi @tasanuma , I have fixed the two problems you mentioned before, please have a look, thank you. |
|
We don't need to fix this checkstyle issue because variable |
tasanuma
reviewed
Nov 30, 2021
...-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
Show resolved
Hide resolved
tasanuma
reviewed
Nov 30, 2021
...p-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeReconfiguration.java
Outdated
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
Merged. Thanks for your contribution, @tomscut! |
|
Thanks @tasanuma for the review and the merge. |
tasanuma
pushed a commit
that referenced
this pull request
Jan 19, 2022
Signed-off-by: Takanobu Asanuma <tasanuma@apache.org> (cherry picked from commit 52ec65f)
|
Cherry-picked it into branch-3.3 with fixing small conflicts. |
Thank @tasanuma for your cherry-picking. I submitted a new PR #3831 with other parameters related to blockReport, but currently there is a conflict with the branch-trunk. I'll resolve the conflict later. I'm sorry I didn't tell you earlier. |
|
@tomscut Thanks for working on it and letting me know. I would like to review it. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…3676) Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16331.
We have a cold data cluster, which stores as EC policy. There are 24 disks on each node and each disk is 7 TB.
Recently, many nodes have more than
10 million blocks, and the interval ofFBRis6has default. Frequent FBR caused great pressure on NN.We want to increase the interval of
FBR, but have to rolling restart the DNs, this operation is very heavy. In this scenario, it is necessary to makedfs.blockreport.intervalMsecreconfigurable.