YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse… #3592

hotcodemacha · 2021-10-27T06:06:20Z

Jira: https://issues.apache.org/jira/browse/YARN-10991
Fix to ignore the grouping "[]" for resourcesStr in parseResourcesString method. Currently, if "]" is present at the end of resourcesStr, it is not ignored.

…ResourcesString method

aajisaka · 2021-11-11T04:07:39Z

@ashutoshcipher Thank you for your fix. The fix looks good to me. Would you add a regression test for this issue? I think you can create a new test class (such as TestClient.java) for this.

hotcodemacha · 2021-11-11T05:52:31Z

@aajisaka Thanks for the review. I will work on adding the regression test.

tomscut

LGTM. Better to add a unit test.

...utedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestClient.java

aajisaka

Thank you @ashutoshcipher for adding the test. I have 2 comments.

hadoop-yetus · 2021-11-22T18:25:42Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 6s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 28s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 26s		trunk passed
+1 💚	mvnsite	0m 33s		trunk passed
+1 💚	javadoc	0m 31s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 26s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 46s		trunk passed
+1 💚	shadedclient	19m 51s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 23s		the patch passed
+1 💚	compile	0m 22s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 22s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 20s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 15s		the patch passed
+1 💚	mvnsite	0m 22s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 46s		the patch passed
+1 💚	shadedclient	19m 20s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 20s		hadoop-yarn-applications-distributedshell in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		103m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3592/6/artifact/out/Dockerfile
GITHUB PR	#3592
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux 167dc1af2a8c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `42cceb9`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3592/6/testReport/
Max. process+thread count	673 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3592/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2021-11-22T18:44:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	40m 25s		trunk passed
+1 💚	compile	0m 29s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	compile	0m 25s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	checkstyle	0m 24s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	javadoc	0m 33s		trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 57s		trunk passed
+1 💚	shadedclient	26m 44s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javac	0m 26s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 16s		the patch passed
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚	javadoc	0m 17s		the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚	spotbugs	0m 55s		the patch passed
+1 💚	shadedclient	25m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	22m 21s		hadoop-yarn-applications-distributedshell in the patch passed.
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		125m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3592/5/artifact/out/Dockerfile
GITHUB PR	#3592
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux c1b673fc501c 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `42cceb9`
Default Java	Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3592/5/testReport/
Max. process+thread count	593 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3592/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka

LGTM, Thank you.

aajisaka · 2021-11-24T09:41:38Z

Merged. Thank you @ashutoshcipher and @tomscut

…ResourcesString method (#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 08f3df3)

…ResourcesString method (apache#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

…ResourcesString method (apache#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 08f3df3)

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse…

51fda80

…ResourcesString method

This comment has been minimized.

Sign in to view

tomscut approved these changes Nov 14, 2021

View reviewed changes

Adding test case for parseResourcesString method for Client class

5b37843

This comment has been minimized.

Sign in to view

adding Apache License

77ee34e

This comment has been minimized.

Sign in to view

formating code as hadoop project code formatter guidance

b7458cf

This comment has been minimized.

Sign in to view

aajisaka reviewed Nov 21, 2021

View reviewed changes

...utedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestClient.java Outdated Show resolved Hide resolved

aajisaka reviewed Nov 21, 2021

View reviewed changes

...utedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestClient.java Outdated Show resolved Hide resolved

aajisaka requested changes Nov 21, 2021

View reviewed changes

hotcodemacha added 2 commits November 22, 2021 22:07

removing glob import and @RunWith

a1bcffa

removing unnecessary imports

42cceb9

hotcodemacha requested a review from aajisaka November 22, 2021 16:41

aajisaka approved these changes Nov 24, 2021

View reviewed changes

aajisaka merged commit 08f3df3 into apache:trunk Nov 24, 2021

aajisaka pushed a commit that referenced this pull request Nov 24, 2021

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse…

17b8ad3

…ResourcesString method (#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 08f3df3)

aajisaka pushed a commit that referenced this pull request Nov 24, 2021

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse…

8502242

…ResourcesString method (#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 08f3df3)

sunchao pushed a commit that referenced this pull request Jan 4, 2022

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse…

dd50261

…ResourcesString method (#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit 08f3df3)

HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse…

97d5cf1

…ResourcesString method (apache#3592) Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse… #3592

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse… #3592

Uh oh!

hotcodemacha commented Oct 27, 2021

Uh oh!

This comment has been minimized.

aajisaka commented Nov 11, 2021

Uh oh!

hotcodemacha commented Nov 11, 2021

Uh oh!

tomscut left a comment •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

aajisaka left a comment

Uh oh!

hadoop-yetus commented Nov 22, 2021

Uh oh!

hadoop-yetus commented Nov 22, 2021

Uh oh!

aajisaka left a comment

Uh oh!

aajisaka commented Nov 24, 2021

Uh oh!

Uh oh!

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse… #3592

YARN-10991. Fix to ignore the grouping "[]" for resourcesStr in parse… #3592

Uh oh!

Conversation

hotcodemacha commented Oct 27, 2021

Uh oh!

This comment has been minimized.

aajisaka commented Nov 11, 2021

Uh oh!

hotcodemacha commented Nov 11, 2021

Uh oh!

tomscut left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Nov 22, 2021

Uh oh!

hadoop-yetus commented Nov 22, 2021

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

aajisaka commented Nov 24, 2021

Uh oh!

Uh oh!

tomscut left a comment •

edited

Loading