HDFS-16227. De-flake TestMover#testMoverWithStripedFile #3429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@aajisaka could you please take a look? It's a known issue. Thanks |
goiri
approved these changes
Sep 15, 2021
| public void testMoverWithStripedFile() throws Exception { | ||
| final Configuration conf = new HdfsConfiguration(); | ||
| initConfWithStripe(conf); | ||
|
|
There was a problem hiding this comment.
I would avoid removing this empty line (and 987).
There was a problem hiding this comment.
Thanks for the review @goiri. The reason why I had to remove at least 2 lines is because of checkstyle warning, this is part of build#1 :)
./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java:871: @Test(timeout = 300000):3: Method length is 151 lines (max allowed is 150). [MethodLength]
There was a problem hiding this comment.
Are you fine with this @goiri? After the recent commit, the method has exactly 150 lines, one more line will create checkstyle warning.
Thanks
There was a problem hiding this comment.
If the goal is to avoid the 150 lines issue, I would prefer trying to make refactor the method a little instead of just removing lines that hurt readability. Not strongly opposed but not ideal.
There was a problem hiding this comment.
Not strongly opposed but not ideal.
I agree with your review, addressed in the latest commit. No change in logic, just the refactor as you have suggested.
jojochuang
reviewed
Sep 16, 2021
...op-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
goiri
approved these changes
Sep 17, 2021
| public void testMoverWithStripedFile() throws Exception { | ||
| final Configuration conf = new HdfsConfiguration(); | ||
| initConfWithStripe(conf); | ||
|
|
There was a problem hiding this comment.
If the goal is to avoid the 150 lines issue, I would prefer trying to make refactor the method a little instead of just removing lines that hurt readability. Not strongly opposed but not ideal.
goiri
approved these changes
Sep 17, 2021
|
🎊 +1 overall
This message was automatically generated. |
jojochuang
approved these changes
Sep 18, 2021
|
@virajjasani Thanks for contribution. @tasanuma @goiri @jojochuang Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
TestMover#testMoverWithStripedFile fails intermittently with stacktrace:
Example of this flaky behaviour: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3386/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
How was this patch tested?
Introduced wait until Namenode reports correct storage type for all blocks of given file as there might be some delay in the reporting.