Skip to content

HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project #3031

merged 1 commit into from
May 25, 2021

Conversation

virajjasani
Copy link
Contributor

No description provided.

@virajjasani virajjasani changed the title HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in HDFS HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in hadoop-hdfs-project May 20, 2021
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 15 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 26s Maven dependency ordering for branch
+1 💚 mvninstall 23m 14s trunk passed
+1 💚 compile 5m 16s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 4m 49s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 21s trunk passed
+1 💚 mvnsite 2m 3s trunk passed
+1 💚 javadoc 1m 34s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 16s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 4m 28s trunk passed
+1 💚 shadedclient 16m 58s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 1m 46s the patch passed
+1 💚 compile 5m 14s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 5m 14s the patch passed
+1 💚 compile 4m 46s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 4m 46s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 1m 14s /results-checkstyle-hadoop-hdfs-project.txt hadoop-hdfs-project: The patch generated 1 new + 924 unchanged - 1 fixed = 925 total (was 925)
+1 💚 mvnsite 1m 47s the patch passed
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 19s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 5s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 4m 38s the patch passed
+1 💚 shadedclient 16m 56s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 320m 6s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 22m 58s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
460m 52s
Reason Tests
Failed junit tests hadoop.hdfs.TestDFSShell
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
hadoop.hdfs.server.datanode.TestDataNodeHotSwapVolumes
hadoop.cli.TestErasureCodingCLI
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/1/artifact/out/Dockerfile
GITHUB PR #3031
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux c0fe397f0f6b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 277e007d64e69247f0062da8859e5a012de50562
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/1/testReport/
Max. process+thread count 2413 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani force-pushed the HADOOP-17720-trunk branch from 277e007 to 71d1f07 Compare May 21, 2021 05:55
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 15 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 12m 22s Maven dependency ordering for branch
+1 💚 mvninstall 22m 56s trunk passed
+1 💚 compile 5m 26s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 compile 5m 0s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 checkstyle 1m 27s trunk passed
+1 💚 mvnsite 2m 5s trunk passed
+1 💚 javadoc 1m 40s trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 32s trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 4m 57s trunk passed
+1 💚 shadedclient 16m 42s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 2m 0s the patch passed
+1 💚 compile 6m 25s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javac 6m 25s the patch passed
+1 💚 compile 4m 54s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 javac 4m 54s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 13s hadoop-hdfs-project: The patch generated 0 new + 921 unchanged - 4 fixed = 921 total (was 925)
+1 💚 mvnsite 1m 51s the patch passed
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 23s the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
+1 💚 javadoc 2m 4s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
+1 💚 spotbugs 5m 14s the patch passed
+1 💚 shadedclient 16m 49s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 357m 47s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 25m 17s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 1m 11s The patch does not generate ASF License warnings.
503m 58s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.TestDecommissioningStatus
hadoop.hdfs.TestDFSShell
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
hadoop.hdfs.server.namenode.ha.TestEditLogTailer
hadoop.hdfs.TestHDFSFileSystemContract
hadoop.cli.TestErasureCodingCLI
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/2/artifact/out/Dockerfile
GITHUB PR #3031
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux 7f2f2b5b56aa 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 71d1f07a7a169fcad36dab7d11940b478e1f9c46
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/2/testReport/
Max. process+thread count 2472 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@tasanuma
Copy link
Member

DummyGroupMapping in hadoop-hdfs-project is still importing org.apache.hadoop.thirdparty.com.google.common.collect.Sets. Seems DummyGroupMapping is not used anywhere, so I think we can delete itself.

@virajjasani
Copy link
Contributor Author

Ah, I see. Thanks @tasanuma. Shall we remove DummyGroupMapping with this PR?

@virajjasani virajjasani force-pushed the HADOOP-17720-trunk branch from 71d1f07 to dfe5ecf Compare May 24, 2021 08:47
@virajjasani
Copy link
Contributor Author

DummyGroupMapping was introduced as part of HDFS-2657 and it was only used in TestHttpFSServer. But now it is no longer in use, hence it's safe to remove. I am fine with removing it either with this PR, or I can create a beginner Jira as follow up task. Any option is fine.
As per the latest revision, DummyGroupMapping is referring to org.apache.hadoop.util.Sets.

@tasanuma
Copy link
Member

@virajjasani Thanks for your investigation. Let's create another jira for removing DummyGroupMapping just in case.

@tasanuma
Copy link
Member

@virajjasani It would be a lot of work, but I think import sentences should be written in alphabetical order as much as possible. I mean import org.apache.hadoop.util.Sets; should be written in the same place where the other org.apache.hadoop.util classes are imported. (IntelliJ will add the import statement in the appropriate place if your press Alt+Enter while the class is still unimported.)

@virajjasani
Copy link
Contributor Author

Sure @tasanuma. Created HDFS-16035 and working on rearranging imports.

@virajjasani virajjasani force-pushed the HADOOP-17720-trunk branch from dfe5ecf to ca88448 Compare May 24, 2021 09:47
@virajjasani
Copy link
Contributor Author

Done @tasanuma. Please take a look, I will rearrange imports in other 2 relevant PRs in the meanwhile.

tasanuma
tasanuma reviewed May 24, 2021
View reviewed changes
...dfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/JournalSet.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to break lines here since the 80-length rule does not apply to import statements.

@virajjasani virajjasani force-pushed the HADOOP-17720-trunk branch from ca88448 to 603cb32 Compare May 24, 2021 10:17
@tasanuma
Copy link
Member

@virajjasani Thanks for updating it quickly. +1 on the latest commit, pending Jenkins.

@virajjasani
Copy link
Contributor Author

Thanks for the reviews @tasanuma. When you get time, please take a look at #3032 and #3033 , updated them with import order changes.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 16 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 16m 1s Maven dependency ordering for branch
+1 💚 mvninstall 21m 32s trunk passed
+1 💚 compile 4m 50s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 4m 32s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 1m 21s trunk passed
+1 💚 mvnsite 2m 48s trunk passed
+1 💚 javadoc 2m 6s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 2m 51s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 5m 10s trunk passed
+1 💚 shadedclient 14m 20s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 2m 12s the patch passed
+1 💚 compile 4m 41s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 4m 41s the patch passed
+1 💚 compile 4m 24s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 4m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 14s hadoop-hdfs-project: The patch generated 0 new + 921 unchanged - 4 fixed = 921 total (was 925)
+1 💚 mvnsite 2m 20s the patch passed
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 44s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 2m 32s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 5m 20s the patch passed
+1 💚 shadedclient 14m 12s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 227m 52s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 6m 14s hadoop-hdfs-httpfs in the patch passed.
+1 💚 unit 18m 31s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 0m 49s The patch does not generate ASF License warnings.
371m 10s
Reason Tests
Failed junit tests hadoop.cli.TestErasureCodingCLI
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/5/artifact/out/Dockerfile
GITHUB PR #3031
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux bdf40a158597 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 603cb32
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/5/testReport/
Max. process+thread count 3385 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/5/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 16 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 15m 49s Maven dependency ordering for branch
+1 💚 mvninstall 24m 8s trunk passed
+1 💚 compile 5m 36s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 compile 4m 59s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 checkstyle 1m 24s trunk passed
+1 💚 mvnsite 2m 51s trunk passed
+1 💚 javadoc 2m 16s trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 3m 4s trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 5m 50s trunk passed
+1 💚 shadedclient 16m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 2m 20s the patch passed
+1 💚 compile 5m 25s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javac 5m 25s the patch passed
+1 💚 compile 5m 11s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 javac 5m 11s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 18s hadoop-hdfs-project: The patch generated 0 new + 921 unchanged - 4 fixed = 921 total (was 925)
+1 💚 mvnsite 2m 38s the patch passed
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 javadoc 1m 53s the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04
+1 💚 javadoc 2m 47s the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
+1 💚 spotbugs 6m 15s the patch passed
+1 💚 shadedclient 16m 31s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 231m 1s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 unit 6m 11s hadoop-hdfs-httpfs in the patch passed.
+1 💚 unit 18m 24s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 0m 47s The patch does not generate ASF License warnings.
386m 57s
Reason Tests
Failed junit tests hadoop.cli.TestErasureCodingCLI
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/6/artifact/out/Dockerfile
GITHUB PR #3031
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell xml spotbugs checkstyle
uname Linux 760e3211744e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 603cb32
Default Java Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/6/testReport/
Max. process+thread count 3144 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3031/6/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

tasanuma
tasanuma reviewed May 25, 2021
View reviewed changes
...oop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NNStorageRetentionManager.java
}

TreeSet<Long> imageTxIds = Sets.newTreeSet(Collections.reverseOrder());
TreeSet<Long> imageTxIds = new TreeSet<>(Collections.reverseOrder());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It is recommended to use the TreeSet constructor directly.
https://github.com/google/guava/blob/v30.1.1/guava/src/com/google/common/collect/Sets.java#L399-L403

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. Hence, I have also created this follow-up Jira HADOOP-17726 for the same so that empty set constructors can be directly created.

tasanuma
tasanuma approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@tasanuma tasanuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed test is not related. +1.

@tasanuma tasanuma merged commit 028ec47 into apache:trunk May 25, 2021
@tasanuma
Copy link
Member

Merged. Thanks for your contribution, @virajjasani.

@virajjasani virajjasani deleted the HADOOP-17720-trunk branch May 25, 2021 11:17
kiran-maturi pushed a commit to kiran-maturi/hadoop that referenced this pull request Nov 24, 2021
@virajjasani
HADOOP-17720. Replace Guava Sets usage by Hadoop's own Sets in HDFS (a…
dc6a639 
…pache#3031)

Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasanuma tasanuma tasanuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@virajjasani @hadoop-yetus @tasanuma