HDFS-15820. Ensure snapshot root trash provisioning happens only post safe mode exit #2682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
approved these changes
Feb 4, 2021
...hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java
Outdated
Show resolved
Hide resolved
| final String msg = | ||
| "Could not provision Trash directory for existing " | ||
| + "snapshottable directories. Exiting Namenode."; | ||
| ExitUtil.terminate(1, msg); |
There was a problem hiding this comment.
Pro: Terminating NN in this case is a sure good way of uncovering an unexpected problems instead of hiding it in the logs.
Con: I wonder if we really should terminate NN when Trash directory fails to be deployed. We could just throw a warning message?
Either way, I'm fine with both. Just a thought.
Change-Id: I8480ac8f7fc07b4160ba2686569ff3cb42f14f48
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Unrelated failures. All flaky tests passed locally for me. Will merge shortly. |
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
… safe mode exit (apache#2682) (cherry picked from commit 19ae0fa) Conflicts: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Namesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDistributedFileSystem.java Change-Id: I5a96c42eb8c4aa3bb700c3e6a07e4cd04fd3af7b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see https://issues.apache.org/jira/browse/HDFS-15820.