HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas… #1797

iwasakims · 2020-01-07T07:06:46Z

No description provided.

…eRenewSocketTimeout.

hadoop-yetus · 2020-01-07T10:52:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	25m 18s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	1m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	18m 30s	trunk passed
+1 💚	compile	3m 21s	trunk passed
+1 💚	checkstyle	0m 59s	trunk passed
+1 💚	mvnsite	2m 8s	trunk passed
+1 💚	shadedclient	16m 3s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	2m 3s	trunk passed
+0 🆗	spotbugs	2m 47s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 54s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 47s	the patch passed
+1 💚	compile	3m 16s	the patch passed
+1 💚	javac	3m 16s	the patch passed
+1 💚	checkstyle	0m 59s	the patch passed
+1 💚	mvnsite	1m 53s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	12m 57s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 50s	the patch passed
+1 💚	findbugs	5m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 3s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	94m 45s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 45s	The patch does not generate ASF License warnings.
		200m 50s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestRedudantBlocks
	hadoop.hdfs.server.namenode.TestNamenodeCapacityReport
	hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/3/artifact/out/Dockerfile
GITHUB PR	#1797
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 9c1050140e57 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 59aac00
Default Java	1.8.0_232
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/3/testReport/
Max. process+thread count	4227 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-01-07T11:30:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	31m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	20m 4s	trunk passed
+1 💚	compile	3m 39s	trunk passed
+1 💚	checkstyle	1m 3s	trunk passed
+1 💚	mvnsite	1m 59s	trunk passed
+1 💚	shadedclient	16m 2s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 52s	trunk passed
+0 🆗	spotbugs	3m 9s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 26s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 56s	the patch passed
+1 💚	compile	3m 37s	the patch passed
+1 💚	javac	3m 37s	the patch passed
+1 💚	checkstyle	0m 52s	the patch passed
+1 💚	mvnsite	1m 48s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 12s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 48s	the patch passed
+1 💚	findbugs	5m 48s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 7s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	142m 35s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 41s	The patch does not generate ASF License warnings.
		257m 15s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestRedudantBlocks
	hadoop.hdfs.TestDistributedFileSystemWithECFile
	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy
	hadoop.hdfs.TestEncryptionZonesWithKMS
	hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/2/artifact/out/Dockerfile
GITHUB PR	#1797
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 18e39deaa52d 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 59aac00
Default Java	1.8.0_232
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/2/testReport/
Max. process+thread count	3513 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-01-07T11:32:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	31m 20s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	1m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	19m 44s	trunk passed
+1 💚	compile	3m 28s	trunk passed
+1 💚	checkstyle	0m 55s	trunk passed
+1 💚	mvnsite	2m 7s	trunk passed
+1 💚	shadedclient	15m 26s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 53s	trunk passed
+0 🆗	spotbugs	2m 58s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 9s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 54s	the patch passed
+1 💚	compile	3m 44s	the patch passed
+1 💚	javac	3m 44s	the patch passed
+1 💚	checkstyle	0m 52s	the patch passed
+1 💚	mvnsite	1m 57s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 12s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 45s	the patch passed
+1 💚	findbugs	5m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 0s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	151m 30s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		265m 3s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestRedudantBlocks
	hadoop.hdfs.client.impl.TestBlockReaderLocal
	hadoop.hdfs.TestDFSInputStream
	hadoop.hdfs.TestDistributedFileSystemWithECFile
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.qjournal.server.TestJournalNodeSync
	hadoop.hdfs.TestDecommissionWithBackoffMonitor
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.TestDeadNodeDetection
	hadoop.hdfs.server.datanode.TestDataNodeUUID
	hadoop.hdfs.TestParallelShortCircuitLegacyRead

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/1/artifact/out/Dockerfile
GITHUB PR	#1797
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ddba568a4ba1 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / 59aac00
Default Java	1.8.0_232
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/1/testReport/
Max. process+thread count	3441 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

aajisaka · 2020-01-08T01:21:49Z

hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSClientRetries.java

          Mockito.anyString());
-      leaseRenewer = client.getLeaseRenewer();
-      leaseRenewer.setRenewalTime(100);
+      LeaseRenewer leaseRenewer2 = client.getLeaseRenewer();


Should we set final to leaseRenewer2 as well as leaseRenewer1?

I'm +1 if that is addressed.

I addressed your comment. Thanks.

aajisaka

+1, thanks.

hadoop-yetus · 2020-01-08T07:35:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	1m 8s	Maven dependency ordering for branch
+1 💚	mvninstall	19m 39s	trunk passed
+1 💚	compile	3m 36s	trunk passed
+1 💚	checkstyle	1m 0s	trunk passed
+1 💚	mvnsite	2m 4s	trunk passed
+1 💚	shadedclient	15m 43s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 58s	trunk passed
+0 🆗	spotbugs	2m 50s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 58s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 1s	the patch passed
+1 💚	compile	3m 42s	the patch passed
+1 💚	javac	3m 42s	the patch passed
+1 💚	checkstyle	1m 1s	the patch passed
+1 💚	mvnsite	1m 57s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 22s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	1m 57s	the patch passed
+1 💚	findbugs	5m 58s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 4s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	146m 12s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		233m 6s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.namenode.TestRedudantBlocks
	hadoop.hdfs.server.namenode.ha.TestHASafeMode
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
	hadoop.hdfs.TestDeadNodeDetection
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.TestBlockStoragePolicy
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestReplaceDatanodeFailureReplication
	hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
	hadoop.hdfs.TestFileCreation

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/4/artifact/out/Dockerfile
GITHUB PR	#1797
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ac5da571e7ce 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `a43c177`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/4/testReport/
Max. process+thread count	4399 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1797/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…eRenewSocketTimeout. (#1797) (cherry picked from commit aba3f6c)

…eRenewSocketTimeout. (apache#1797)

…eRenewSocketTimeout. (apache#1797) (cherry picked from commit aba3f6c)

…eRenewSocketTimeout. (apache#1797) (cherry picked from commit aba3f6c) (cherry picked from commit c5580af) Change-Id: Icf0b6ab814be87032267c157683cb4dc29af3ee8

iwasakims added 3 commits January 7, 2020 16:03

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas…

acd8082

…eRenewSocketTimeout.

addressed checkstyle warning.

0de30e9

should wait till current LeaseRenewer thread stops to avoid race.

3218cc4

aajisaka reviewed Jan 8, 2020

View reviewed changes

marked local var as final to align with existing one.

0361560

aajisaka self-requested a review January 8, 2020 03:51

aajisaka approved these changes Jan 8, 2020

View reviewed changes

iwasakims merged commit aba3f6c into apache:trunk Jan 8, 2020

asfgit pushed a commit that referenced this pull request Jan 8, 2020

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas…

3e17b47

…eRenewSocketTimeout. (#1797) (cherry picked from commit aba3f6c)

asfgit pushed a commit that referenced this pull request Jan 8, 2020

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas…

c5580af

…eRenewSocketTimeout. (#1797) (cherry picked from commit aba3f6c)

RogPodge pushed a commit to RogPodge/hadoop that referenced this pull request Mar 25, 2020

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas…

33ebecd

…eRenewSocketTimeout. (apache#1797)

bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 2, 2020

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas…

b535248

…eRenewSocketTimeout. (apache#1797) (cherry picked from commit aba3f6c)

bentito pushed a commit to bentito/hadoop that referenced this pull request Dec 3, 2020

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas…

ea9ea14

…eRenewSocketTimeout. (apache#1797) (cherry picked from commit aba3f6c)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas… #1797

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas… #1797

Uh oh!

iwasakims commented Jan 7, 2020

Uh oh!

hadoop-yetus commented Jan 7, 2020

Uh oh!

hadoop-yetus commented Jan 7, 2020

Uh oh!

hadoop-yetus commented Jan 7, 2020

Uh oh!

aajisaka Jan 8, 2020

Uh oh!

aajisaka Jan 8, 2020

Uh oh!

iwasakims Jan 8, 2020

Uh oh!

aajisaka left a comment

Uh oh!

hadoop-yetus commented Jan 8, 2020

Uh oh!

Uh oh!

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas… #1797

HDFS-15077. Fix intermittent failure of TestDFSClientRetries#testLeas… #1797

Uh oh!

Conversation

iwasakims commented Jan 7, 2020

Uh oh!

hadoop-yetus commented Jan 7, 2020

Uh oh!

hadoop-yetus commented Jan 7, 2020

Uh oh!

hadoop-yetus commented Jan 7, 2020

Uh oh!

aajisaka Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

aajisaka Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

iwasakims Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jan 8, 2020

Uh oh!

Uh oh!