Skip to content

Conversation

belugabehr
Copy link
Contributor

@belugabehr belugabehr commented Nov 13, 2019

Unify logging style in UserGroupInformation class.

  • Remove superfluous logging guards
  • Remove superfluous String.format
  • Simplify
  • Other

https://issues.apache.org/jira/browse/HADOOP-16691

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 2954 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1390 trunk passed
+1 compile 1295 trunk passed
+1 checkstyle 53 trunk passed
+1 mvnsite 92 trunk passed
+1 shadedclient 1056 branch has no errors when building and testing our client artifacts.
+1 javadoc 97 trunk passed
0 spotbugs 143 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 141 trunk passed
_ Patch Compile Tests _
+1 mvninstall 60 the patch passed
+1 compile 1238 the patch passed
+1 javac 1238 the patch passed
+1 checkstyle 52 hadoop-common-project/hadoop-common: The patch generated 0 new + 77 unchanged - 2 fixed = 77 total (was 79)
+1 mvnsite 92 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 895 patch has no errors when building and testing our client artifacts.
+1 javadoc 98 the patch passed
+1 findbugs 156 the patch passed
_ Other Tests _
+1 unit 625 hadoop-common in the patch passed.
+1 asflicense 52 The patch does not generate ASF License warnings.
10429
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1716/1/artifact/out/Dockerfile
GITHUB PR #1716
JIRA Issue HADOOP-16691
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 47ce2dbdfc16 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / df6b316
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1716/1/testReport/
Max. process+thread count 1370 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1716/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 2969 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 mvninstall 1145 trunk passed
+1 compile 1052 trunk passed
+1 checkstyle 52 trunk passed
+1 mvnsite 82 trunk passed
+1 shadedclient 970 branch has no errors when building and testing our client artifacts.
+1 javadoc 95 trunk passed
0 spotbugs 136 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 132 trunk passed
_ Patch Compile Tests _
+1 mvninstall 55 the patch passed
+1 compile 1163 the patch passed
+1 javac 1163 the patch passed
+1 checkstyle 49 hadoop-common-project/hadoop-common: The patch generated 0 new + 77 unchanged - 2 fixed = 77 total (was 79)
+1 mvnsite 85 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 875 patch has no errors when building and testing our client artifacts.
+1 javadoc 105 the patch passed
+1 findbugs 149 the patch passed
_ Other Tests _
+1 unit 601 hadoop-common in the patch passed.
+1 asflicense 48 The patch does not generate ASF License warnings.
9735
Subsystem Report/Notes
Docker Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1716/2/artifact/out/Dockerfile
GITHUB PR #1716
JIRA Issue HADOOP-16691
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 4808760ed584 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 73a386a
Default Java 1.8.0_222
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-1716/2/testReport/
Max. process+thread count 1364 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-1716/2/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@goiri goiri merged commit d0302d3 into apache:trunk Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants