Check report #1347

elek · 2019-08-24T11:31:20Z

No description provided.

hadoop-yetus · 2019-08-24T16:07:40Z

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java


 /**
 * OzoneACL classes define bucket ACLs used in OZONE.
+ * 


whitespace:end of line

hadoop-yetus · 2019-08-24T16:07:42Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+
+
+#Collect of all of the FAILED results
+for dir in $(find "." -name surefire-reports); do


shellcheck:12: warning: For loops over find output are fragile. Use find -exec or a while read loop. [SC2044]

hadoop-yetus · 2019-08-24T16:07:43Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+
+#Collect of all of the FAILED results
+for dir in $(find "." -name surefire-reports); do
+   for file in $(grep -l -r FAILURE --include="*.txt" $dir | grep -v output.txt ); do


shellcheck:16: note: To read lines rather than words, pipe/redirect to a 'while read' loop. [SC2013]
shellcheck:55: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-24T16:07:44Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+#Collect of all of the FAILED results
+for dir in $(find "." -name surefire-reports); do
+   for file in $(grep -l -r FAILURE --include="*.txt" $dir | grep -v output.txt ); do
+      DIR_OF_TESTFILE=$(dirname $file)


shellcheck:33: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-24T16:07:46Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+for dir in $(find "." -name surefire-reports); do
+   for file in $(grep -l -r FAILURE --include="*.txt" $dir | grep -v output.txt ); do
+      DIR_OF_TESTFILE=$(dirname $file)
+      NAME_OF_TESTFILE=$(basename $file)


shellcheck:35: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-24T16:07:47Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+      DIR_OF_TESTFILE=$(dirname $file)
+      NAME_OF_TESTFILE=$(basename $file)
+      NAME_OF_TEST="${NAME_OF_TESTFILE%.*}"
+      DESTDIRNAME=$(realpath --relative-to="$PWD" $DIR_OF_TESTFILE/../..)


shellcheck:51: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-24T16:07:48Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+      NAME_OF_TEST="${NAME_OF_TESTFILE%.*}"
+      DESTDIRNAME=$(realpath --relative-to="$PWD" $DIR_OF_TESTFILE/../..)
+      mkdir -p "$REPORT_DIR/$DESTDIRNAME"
+      cp -r "$DIR_OF_TESTFILE/"*$NAME_OF_TEST* "$REPORT_DIR/$DESTDIRNAME/"


shellcheck:33: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-24T16:07:50Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+printf "   Failing tests: \n\n" > "$SUMMARY_FILE"
+for TEST_RESULT_FILE in $(find "$REPORT_DIR" -name "*.txt" | grep -v output); do
+
+    FAILURES=$(cat $TEST_RESULT_FILE | grep FAILURE | grep "Tests run" | awk '{print $18}' | sort | uniq)


shellcheck:20: note: Double quote to prevent globbing and word splitting. [SC2086]
shellcheck:20: note: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. [SC2002]

hadoop-yetus · 2019-08-24T16:07:51Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+    FAILURES=$(cat $TEST_RESULT_FILE | grep FAILURE | grep "Tests run" | awk '{print $18}' | sort | uniq)
+
+    for FAILURE in $FAILURES; do
+        printf "      $FAILURE\n" >> "$SUMMARY_FILE"


shellcheck:16: note: Don't use variables in the printf format string. Use printf "..%s.." "$foo". [SC2059]

hadoop-yetus · 2019-08-24T16:07:52Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+
+    for FAILURE in $FAILURES; do
+        printf "      $FAILURE\n" >> "$SUMMARY_FILE"
+        TEST_RESULT_LOCATION=$(realpath --relative-to=$REPORT_DIR $TEST_RESULT_FILE)


shellcheck:55: note: Double quote to prevent globbing and word splitting. [SC2086]
shellcheck:67: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-24T16:07:53Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+    for FAILURE in $FAILURES; do
+        printf "      $FAILURE\n" >> "$SUMMARY_FILE"
+        TEST_RESULT_LOCATION=$(realpath --relative-to=$REPORT_DIR $TEST_RESULT_FILE)
+        printf "            (result)[./$TEST_RESULT_LOCATION]\n\n" >> "$SUMMARY_FILE"


shellcheck:16: note: Don't use variables in the printf format string. Use printf "..%s.." "$foo". [SC2059]

hadoop-yetus · 2019-08-24T16:07:55Z

hadoop-ozone/dev-support/checks/integration.sh

+REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target"}
+mkdir -p "$REPORT_DIR"
+
+source "$DIR/_mvn_unit_report.sh"


shellcheck:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]

hadoop-yetus · 2019-08-24T16:07:56Z

hadoop-ozone/dev-support/checks/unit.sh

+
+REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target"}
+mkdir -p "$REPORT_DIR"
+


shellcheck:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]

hadoop-yetus · 2019-08-24T16:07:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	4	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
0	@author	0	Skipping @author checks as author.sh has been patched.
+1	test4tests	0	The patch appears to include 46 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	28	Maven dependency ordering for branch
+1	mvninstall	625	trunk passed
+1	compile	400	trunk passed
+1	checkstyle	84	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	803	branch has no errors when building and testing our client artifacts.
+1	javadoc	178	trunk passed
0	spotbugs	476	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	700	trunk passed
		_ Patch Compile Tests _
0	mvndep	42	Maven dependency ordering for patch
+1	mvninstall	562	the patch passed
+1	compile	405	the patch passed
+1	javac	107	hadoop-hdds in the patch passed.
+1	javac	298	hadoop-ozone generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)
-0	checkstyle	46	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
-1	shellcheck	2	The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	xml	8	The patch has no ill-formed XML file.
+1	shadedclient	696	patch has no errors when building and testing our client artifacts.
-1	javadoc	95	hadoop-ozone generated 1 new + 27 unchanged - 1 fixed = 28 total (was 28)
+1	findbugs	729	the patch passed
		_ Other Tests _
-1	unit	323	hadoop-hdds in the patch failed.
-1	unit	61	hadoop-ozone in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		6264

Reason	Tests
Failed junit tests	hadoop.hdds.scm.block.TestBlockManager
	hadoop.ozone.TestOmUtils

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/Dockerfile
GITHUB PR	#1347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml shellcheck shelldocs
uname	Linux 9081334c6268 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `d2225c8`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
shellcheck	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/diff-patch-shellcheck.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/whitespace-eol.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/patch-unit-hadoop-hdds.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/testReport/
Max. process+thread count	488 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone hadoop-ozone/client hadoop-ozone/common hadoop-ozone/datanode hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozonefs hadoop-ozone/s3gateway hadoop-ozone/tools U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/1/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-27T07:26:30Z

hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java


 /**
 * OzoneACL classes define bucket ACLs used in OZONE.
+ * 


whitespace:end of line

hadoop-yetus · 2019-08-27T07:26:32Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+
+
+#Collect of all of the FAILED results
+for dir in $(find "." -name surefire-reports); do


shellcheck:12: warning: For loops over find output are fragile. Use find -exec or a while read loop. [SC2044]

hadoop-yetus · 2019-08-27T07:26:33Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+
+#Collect of all of the FAILED results
+for dir in $(find "." -name surefire-reports); do
+   for file in $(grep -l -r FAILURE --include="*.txt" $dir | grep -v output.txt ); do


shellcheck:16: note: To read lines rather than words, pipe/redirect to a 'while read' loop. [SC2013]
shellcheck:55: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-27T07:26:35Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+#Collect of all of the FAILED results
+for dir in $(find "." -name surefire-reports); do
+   for file in $(grep -l -r FAILURE --include="*.txt" $dir | grep -v output.txt ); do
+      DIR_OF_TESTFILE=$(dirname $file)


shellcheck:33: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-27T07:26:36Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+for dir in $(find "." -name surefire-reports); do
+   for file in $(grep -l -r FAILURE --include="*.txt" $dir | grep -v output.txt ); do
+      DIR_OF_TESTFILE=$(dirname $file)
+      NAME_OF_TESTFILE=$(basename $file)


shellcheck:35: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-27T07:26:38Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+      DIR_OF_TESTFILE=$(dirname $file)
+      NAME_OF_TESTFILE=$(basename $file)
+      NAME_OF_TEST="${NAME_OF_TESTFILE%.*}"
+      DESTDIRNAME=$(realpath --relative-to="$PWD" $DIR_OF_TESTFILE/../..)


shellcheck:51: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-27T07:26:39Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+      NAME_OF_TEST="${NAME_OF_TESTFILE%.*}"
+      DESTDIRNAME=$(realpath --relative-to="$PWD" $DIR_OF_TESTFILE/../..)
+      mkdir -p "$REPORT_DIR/$DESTDIRNAME"
+      cp -r "$DIR_OF_TESTFILE/"*$NAME_OF_TEST* "$REPORT_DIR/$DESTDIRNAME/"


shellcheck:33: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-27T07:26:41Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+printf "   Failing tests: \n\n" > "$SUMMARY_FILE"
+for TEST_RESULT_FILE in $(find "$REPORT_DIR" -name "*.txt" | grep -v output); do
+
+    FAILURES=$(cat $TEST_RESULT_FILE | grep FAILURE | grep "Tests run" | awk '{print $18}' | sort | uniq)


shellcheck:20: note: Double quote to prevent globbing and word splitting. [SC2086]
shellcheck:20: note: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead. [SC2002]

hadoop-yetus · 2019-08-27T07:26:43Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+    FAILURES=$(cat $TEST_RESULT_FILE | grep FAILURE | grep "Tests run" | awk '{print $18}' | sort | uniq)
+
+    for FAILURE in $FAILURES; do
+        printf "      $FAILURE\n" >> "$SUMMARY_FILE"


shellcheck:16: note: Don't use variables in the printf format string. Use printf "..%s.." "$foo". [SC2059]

hadoop-yetus · 2019-08-27T07:26:44Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+
+    for FAILURE in $FAILURES; do
+        printf "      $FAILURE\n" >> "$SUMMARY_FILE"
+        TEST_RESULT_LOCATION=$(realpath --relative-to=$REPORT_DIR $TEST_RESULT_FILE)


shellcheck:55: note: Double quote to prevent globbing and word splitting. [SC2086]
shellcheck:67: note: Double quote to prevent globbing and word splitting. [SC2086]

hadoop-yetus · 2019-08-27T07:26:46Z

hadoop-ozone/dev-support/checks/_mvn_unit_report.sh

+    for FAILURE in $FAILURES; do
+        printf "      $FAILURE\n" >> "$SUMMARY_FILE"
+        TEST_RESULT_LOCATION=$(realpath --relative-to=$REPORT_DIR $TEST_RESULT_FILE)
+        printf "            (result)[./$TEST_RESULT_LOCATION]\n\n" >> "$SUMMARY_FILE"


shellcheck:16: note: Don't use variables in the printf format string. Use printf "..%s.." "$foo". [SC2059]

hadoop-yetus · 2019-08-27T07:26:47Z

hadoop-ozone/dev-support/checks/integration.sh

+REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target"}
+mkdir -p "$REPORT_DIR"
+
+source "$DIR/_mvn_unit_report.sh"


shellcheck:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]

hadoop-yetus · 2019-08-27T07:26:49Z

hadoop-ozone/dev-support/checks/unit.sh

+
+REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target"}
+mkdir -p "$REPORT_DIR"
+


shellcheck:1: warning: Can't follow non-constant source. Use a directive to specify location. [SC1090]

hadoop-yetus · 2019-08-27T07:26:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	6	No case conflicting files found.
0	shelldocs	0	Shelldocs was not available.
0	@author	0	Skipping @author checks as author.sh has been patched.
+1	test4tests	0	The patch appears to include 46 new or modified test files.
		_ trunk Compile Tests _
0	mvndep	479	Maven dependency ordering for branch
+1	mvninstall	820	trunk passed
+1	compile	395	trunk passed
+1	checkstyle	100	trunk passed
+1	mvnsite	0	trunk passed
+1	shadedclient	777	branch has no errors when building and testing our client artifacts.
+1	javadoc	193	trunk passed
0	spotbugs	424	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	632	trunk passed
		_ Patch Compile Tests _
0	mvndep	48	Maven dependency ordering for patch
+1	mvninstall	532	the patch passed
+1	compile	391	the patch passed
+1	javac	112	hadoop-hdds in the patch passed.
+1	javac	279	hadoop-ozone generated 0 new + 5 unchanged - 3 fixed = 5 total (was 8)
-0	checkstyle	52	hadoop-ozone: The patch generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
+1	mvnsite	0	the patch passed
-1	shellcheck	1	The patch generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
-1	whitespace	0	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1	xml	7	The patch has no ill-formed XML file.
+1	shadedclient	694	patch has no errors when building and testing our client artifacts.
-1	javadoc	101	hadoop-ozone generated 1 new + 26 unchanged - 1 fixed = 27 total (was 27)
+1	findbugs	633	the patch passed
		_ Other Tests _
+1	unit	319	hadoop-hdds in the patch passed.
-1	unit	67	hadoop-ozone in the patch failed.
+1	asflicense	54	The patch does not generate ASF License warnings.
		6791

Reason	Tests
Failed junit tests	hadoop.ozone.TestOmUtils

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/artifact/out/Dockerfile
GITHUB PR	#1347
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml shellcheck shelldocs
uname	Linux a84be8aa2abd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `b69ac57`
Default Java	1.8.0_222
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/artifact/out/diff-checkstyle-hadoop-ozone.txt
shellcheck	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/artifact/out/diff-patch-shellcheck.txt
whitespace	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/artifact/out/whitespace-eol.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/artifact/out/diff-javadoc-javadoc-hadoop-ozone.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/artifact/out/patch-unit-hadoop-ozone.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/testReport/
Max. process+thread count	484 (vs. ulimit of 5500)
modules	C: hadoop-hdds/common hadoop-ozone hadoop-ozone/client hadoop-ozone/common hadoop-ozone/datanode hadoop-ozone/dist hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/ozonefs hadoop-ozone/s3gateway hadoop-ozone/tools U: .
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-1347/2/console
versions	git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

aajisaka · 2021-02-10T23:53:36Z

Ozone has been separated from Hadoop. Closing.

elek added 11 commits August 23, 2019 12:38

HDDS-738. Removing REST protocol support from OzoneClient

0a94d00

checkstyle + unit test fixes

a31efcb

unit fixes

3adcd41

checkstyle + rat fixes

185cca6

fix tests

7363e9f

fix unit tests

fbcf8c7

all the tests can report

3b9d6d0

restore helper script

8c1f92d

reenable unit test execution

f3ac17e

Acceptance test requires full build.

f63d6a3

adding rat and author violations

ec848c0

hadoop-yetus reviewed Aug 24, 2019

View reviewed changes

hadoop-yetus reviewed Aug 27, 2019

View reviewed changes

aajisaka closed this Feb 10, 2021



		#Collect of all of the FAILED results
		for dir in $(find "." -name surefire-reports); do


		REPORT_DIR=${OUTPUT_DIR:-"$DIR/../../../target"}
		mkdir -p "$REPORT_DIR"

Check report #1347

Check report #1347

Uh oh!

Conversation

elek commented Aug 24, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 24, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Aug 27, 2019

Uh oh!

aajisaka commented Feb 10, 2021

Uh oh!

Uh oh!