Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2178] Remove deprecated GaaSObservabilityEventExperimental #4081

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

iPalash
Copy link
Contributor

@iPalash iPalash commented Dec 9, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

The avro file GaaSObservabilityEventExperimental has been split into GaaSFlowObservabilityEvent and GaaSJobObservabilityEvent and since been deprecated.

Any future changes to the structure found in the deprecated file (like jobStatus ; containing only the failure states as of now) will require unnecessary changes to the deprecated version as well.

Removing the deprecated file simplifies such changes.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    The deprecated file isn't used anywhere.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@iPalash iPalash changed the title Remove GaaSObservabilityEventExperimental.avsc Remove deprecated GaaSObservabilityEventExperimental Dec 9, 2024
@iPalash iPalash changed the title Remove deprecated GaaSObservabilityEventExperimental [GOBBLIN-2178] Remove deprecated GaaSObservabilityEventExperimental Dec 10, 2024
@phet phet merged commit f4728fb into apache:master Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants