[FLINK-38468][flink-table-planner] When the coalesce parameter contains a function, convert it to case when #27055
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rule，when including functions, it will fall back to case when
davidradl
reviewed
Sep 29, 2025
| } | ||
| } | ||
|
|
||
| if (containsFunctionCalls(call)) { |
There was a problem hiding this comment.
Please could you raise a Jira for this with the motivation behind this change and reference the Jira in the title. From the code it looks like this is more than an optimization it is adding function specific code, it would be good to call out the value being added here and/or symptoms/ behaviour/ errors that might be seen prior to this change.
As there is logic added in the change , I suggest adding unit tests for the code you have added.
There was a problem hiding this comment.
Hello, I have added Jira and unit tests
@davidradl
github-actions
bot
added
the
community-reviewed
ChengJie1053
changed the title
ChengJie1053
changed the title
…ns a function, convert it to case when
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize RemoveUnreachableCoalesceArgumentsRule rule，when including functions, it will fall back to case when
FLINK-38468