Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36208][core] use ThreadLocalRandom in AbstractID #25286

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Sep 4, 2024

What is the purpose of the change

to improve performance of AbstractID by using ThreadLocalRandom

https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadLocalRandom.html

Brief change log

  • use ThreadLocalRandom in AbstractID

Verifying this change

Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): No
  • The public API, i.e., is any changed class annotated with @Public(Evolving): No
  • The serializers: No
  • The runtime per-record code paths (performance sensitive): No
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: No
  • The S3 file system connector: No

Documentation

  • Does this pull request introduce a new feature? NO
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 4, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@sullis
Copy link
Contributor Author

sullis commented Sep 8, 2024

Ready for review

@sullis
Copy link
Contributor Author

sullis commented Sep 11, 2024

this PR is ready for review.

Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Pls. make sure to run mvn spotless:apply that formats the imports properly, update the PR and produce a successful CI run.

@sullis
Copy link
Contributor Author

sullis commented Sep 13, 2024

Pls. make sure to run mvn spotless:apply that formats the imports properly

Done.

@ferenc-csaky
Copy link
Contributor

Can you pls. rebase to the latest master state? There was an orthogonal issue that failed the CI but that is fixed now, so the next run should be successful.

@sullis
Copy link
Contributor Author

sullis commented Sep 14, 2024

Can you pls. rebase to the latest master state? There was an orthogonal issue that failed the CI but that is fixed now, so the next run should be successful.

Rebase done. Ready for review.

Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge it tomorrow EOD (CEST) if no objections until then.

@ferenc-csaky ferenc-csaky merged commit 96b8425 into apache:master Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants