Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.20 The spelling correction of the ogg format parameter in the json format part of the Chinese document #25281

Closed
wants to merge 5 commits into from

Conversation

bugbubug
Copy link

@bugbubug bugbubug commented Sep 2, 2024

What is the purpose of the change

This pull request corrects a spelling error in the JSON format part of the Chinese documentation. Specifically, it changes primary_keys to primary-keys.

Brief change log

  • Corrected spelling from primary_keys to primary-keys in the JSON format part of the Chinese documentation.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@bugbubug bugbubug marked this pull request as draft September 2, 2024 13:48
@flinkbot
Copy link
Collaborator

flinkbot commented Sep 2, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@bugbubug
Copy link
Author

bugbubug commented Sep 6, 2024

@flinkbot run azure

@bugbubug bugbubug marked this pull request as ready for review September 6, 2024 08:25
@bugbubug bugbubug changed the base branch from master to release-1.20 September 6, 2024 08:28
@bugbubug
Copy link
Author

bugbubug commented Sep 6, 2024

@flinkbot run azure

@bugbubug bugbubug closed this Sep 11, 2024
@bugbubug bugbubug deleted the release-1.20-rico branch September 11, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants