Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35795][API] Introduce ProcessFunction Attribute in DataStream API V2 #25276

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[FLINK-35795][API] Introduce ProcessFunction Attribute in DataStream API V2 #25276

merged 2 commits into from
Sep 12, 2024

Conversation

codenohup
Copy link
Contributor

What is the purpose of the change

Introduce ProcessFunction Attribute in DataStream API V2.

Brief change log

Introduce the framework of ProcessFunction Attribute.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): yes
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 2, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

reswqa
reswqa reviewed Sep 2, 2024
View reviewed changes
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I left some comments, PTAL.

flink-core-api/src/main/java/org/apache/flink/api/common/attribute/Attribute.java Outdated Show resolved Hide resolved
flink-core-api/src/main/java/org/apache/flink/api/common/attribute/Attribute.java Outdated Show resolved Hide resolved
...g/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorWithOperatorAttributesTest.java Outdated Show resolved Hide resolved
flink-datastream/src/main/java/org/apache/flink/datastream/impl/stream/GlobalStreamImpl.java Outdated Show resolved Hide resolved
...g/apache/flink/datastream/impl/stream/ProcessConfigurableTwoNonKeyedPartitionStreamImpl.java Outdated Show resolved Hide resolved
.../org/apache/flink/datastream/impl/attribute/StreamingJobGraphGeneratorWithAttributeTest.java Show resolved Hide resolved
.../org/apache/flink/datastream/impl/attribute/StreamingJobGraphGeneratorWithAttributeTest.java Outdated Show resolved Hide resolved
.../org/apache/flink/datastream/impl/attribute/StreamingJobGraphGeneratorWithAttributeTest.java Outdated Show resolved Hide resolved
...tastream/src/main/java/org/apache/flink/datastream/impl/stream/KeyedPartitionStreamImpl.java Show resolved Hide resolved
...tastream/src/main/java/org/apache/flink/datastream/impl/stream/KeyedPartitionStreamImpl.java Outdated Show resolved Hide resolved
@codenohup
Copy link
Contributor Author

Thanks for the contribution!

I left some comments, PTAL.

@reswqa Thank you for your carefully review. I have made modifications based on your suggestions.

reswqa
reswqa approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@reswqa reswqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@reswqa reswqa merged commit 4d13170 into apache:master Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reswqa reswqa reswqa approved these changes

Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codenohup @flinkbot @reswqa