Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36185][core] Remove RuntimeContext#getExecutionConfig #25270

Conversation

JunRuiLee
Copy link
Contributor

What is the purpose of the change

Remove RuntimeContext#getExecutionConfig

Brief change log

Remove RuntimeContext#getExecutionConfig

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 30, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JunRuiLee JunRuiLee force-pushed the remove-runtimeContext-getexecutionconfig branch 2 times, most recently from 8aa77fe to d3cbb2a Compare August 30, 2024 06:52
@JunRuiLee JunRuiLee force-pushed the remove-runtimeContext-getexecutionconfig branch 7 times, most recently from b677095 to eec59f5 Compare September 11, 2024 01:57
@JunRuiLee
Copy link
Contributor Author

After discussing with @dianfu , this PR temporarily disables the PyFlink end-to-end case that uses Kafka legacy source. @dianfu will address the necessary fixes specifically for the PyFlink cases.

@JunRuiLee JunRuiLee force-pushed the remove-runtimeContext-getexecutionconfig branch 2 times, most recently from 8380f11 to 57601b4 Compare September 11, 2024 03:53
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JunRuiLee JunRuiLee force-pushed the remove-runtimeContext-getexecutionconfig branch from 57601b4 to e517922 Compare September 11, 2024 07:45
@zhuzhurk zhuzhurk closed this in c7b1f4b Sep 12, 2024
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants