-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36249][streaming-java] Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects. #25256
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
from
August 26, 2024 10:26
c168fa3
to
04e12db
Compare
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
9 times, most recently
from
August 29, 2024 03:12
4d6beed
to
91a3942
Compare
JunRuiLee
changed the title
[FLINK-33678][streaming-java] Remove configuration getters/setters that return/set complex Java objects.
[FLINK-33678][streaming-java] Remove RestartStrategies related public API.
Aug 29, 2024
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
2 times, most recently
from
August 29, 2024 07:06
f25fa58
to
27af78c
Compare
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
from
September 11, 2024 03:03
27af78c
to
dffab01
Compare
JunRuiLee
changed the title
[FLINK-33678][streaming-java] Remove RestartStrategies related public API.
[FLINK-36249][streaming-java] Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects.
Sep 11, 2024
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
2 times, most recently
from
September 12, 2024 07:05
685309d
to
6331991
Compare
zhuzhurk
reviewed
Sep 12, 2024
...ase/src/test/java/org/apache/flink/connector/base/source/reader/CoordinatedSourceITCase.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java
Outdated
Show resolved
Hide resolved
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
4 times, most recently
from
September 13, 2024 05:43
fadebc6
to
81db096
Compare
zhuzhurk
reviewed
Sep 13, 2024
flink-python/docs/reference/pyflink.datastream/stream_execution_environment.rst
Outdated
Show resolved
Hide resolved
...rg/apache/flink/runtime/executiongraph/failover/RestartBackoffTimeStrategyFactoryLoader.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/streaming/util/RestartStrategyUtils.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/streaming/util/RestartStrategyUtils.java
Outdated
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/ArchivedExecutionConfig.java
Outdated
Show resolved
Hide resolved
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
from
September 13, 2024 08:53
516b675
to
be9a692
Compare
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
2 times, most recently
from
September 13, 2024 12:09
42558db
to
bd1401e
Compare
zhuzhurk
reviewed
Sep 13, 2024
...sts/flink-state-evolution-test/src/main/java/org/apache/flink/test/StatefulStreamingJob.java
Outdated
Show resolved
Hide resolved
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
4 times, most recently
from
September 14, 2024 16:50
53af171
to
4fdc1c3
Compare
…o support job configuration passing.
…ation getters/setters that return/set complex Java objects.
JunRuiLee
force-pushed
the
FLINK-33678-part-restart
branch
from
September 17, 2024 02:20
4fdc1c3
to
0545605
Compare
zhuzhurk
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Sep 24, 2024
…ation getters/setters that return/set complex Java objects. This closes apache#25256.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
FLINK-33581/FLIP-381 Deprecate configuration getters/setters that return/set complex Java objects.
In Flink 2.0 we should remove these deprecated method and fields. This change will prevent users from configuring their jobs by passing complex Java objects, encouraging them to use ConfigOption instead.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation