Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36249][streaming-java] Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects. #25256

Closed
wants to merge 2 commits into from

Conversation

JunRuiLee
Copy link
Contributor

What is the purpose of the change

FLINK-33581/FLIP-381 Deprecate configuration getters/setters that return/set complex Java objects.
In Flink 2.0 we should remove these deprecated method and fields. This change will prevent users from configuring their jobs by passing complex Java objects, encouraging them to use ConfigOption instead.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@JunRuiLee JunRuiLee marked this pull request as draft August 26, 2024 08:35
@flinkbot
Copy link
Collaborator

flinkbot commented Aug 26, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@JunRuiLee JunRuiLee force-pushed the FLINK-33678-part-restart branch 9 times, most recently from 4d6beed to 91a3942 Compare August 29, 2024 03:12
@JunRuiLee JunRuiLee changed the title [FLINK-33678][streaming-java] Remove configuration getters/setters that return/set complex Java objects. [FLINK-33678][streaming-java] Remove RestartStrategies related public API. Aug 29, 2024
@JunRuiLee JunRuiLee force-pushed the FLINK-33678-part-restart branch 2 times, most recently from f25fa58 to 27af78c Compare August 29, 2024 07:06
@JunRuiLee JunRuiLee marked this pull request as ready for review August 30, 2024 01:43
@JunRuiLee JunRuiLee marked this pull request as draft August 30, 2024 04:36
@JunRuiLee JunRuiLee marked this pull request as ready for review September 3, 2024 12:22
@JunRuiLee JunRuiLee changed the title [FLINK-33678][streaming-java] Remove RestartStrategies related public API. [FLINK-36249][streaming-java] Remove RestartStrategy-related configuration getters/setters that return/set complex Java objects. Sep 11, 2024
@JunRuiLee JunRuiLee force-pushed the FLINK-33678-part-restart branch 2 times, most recently from 685309d to 6331991 Compare September 12, 2024 07:05
@JunRuiLee JunRuiLee force-pushed the FLINK-33678-part-restart branch 4 times, most recently from fadebc6 to 81db096 Compare September 13, 2024 05:43
@JunRuiLee JunRuiLee force-pushed the FLINK-33678-part-restart branch 2 times, most recently from 42558db to bd1401e Compare September 13, 2024 12:09
@JunRuiLee JunRuiLee force-pushed the FLINK-33678-part-restart branch 4 times, most recently from 53af171 to 4fdc1c3 Compare September 14, 2024 16:50
…ation getters/setters that return/set complex Java objects.
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhuzhurk zhuzhurk closed this in 4e82510 Sep 18, 2024
@JunRuiLee JunRuiLee deleted the FLINK-33678-part-restart branch September 18, 2024 05:43
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Sep 24, 2024
…ation getters/setters that return/set complex Java objects.

This closes apache#25256.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants