[BP-1.14][FLINK-27399][Connector/Pulsar] [Connector/Pulsar] Change initial consuming position setting logic for better handle the checkpoint. #20565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syhily
force-pushed
the
backport/release-1.14/FLINK-27399
branch
from
81e7328 to
04dfdd4
Compare
tisonkun
reviewed
Aug 14, 2022
| @@ -36,13 +36,15 @@ under the License. | |||
| <packaging>jar</packaging> | |||
|
|
|||
| <properties> | |||
| <pulsar.version>2.8.0</pulsar.version> | |||
| <pulsar.version>2.9.1</pulsar.version> | |||
There was a problem hiding this comment.
How is this version bump necessary?
Basically, we should not bump version in a patch version, especially which can introduce new features.
There was a problem hiding this comment.
We have to use this version bump because the underlying API is introduced on Pulsar 2.9.x.
Yep. The testing tools are introduced for adding transaction support for mocked Pulsar. |
|
@PatrickRen Can you help me review this backport issue? |
…ting logic for better handle the checkpoint. (apache#19972) * Change the initial start cursor and stop cursor to better handle the consuming behaviors. * Create the initial subscription instead seek every time. This should fix the wrong position setting. * Fix the wrong stop cursor, make sure it stops at the correct space * Drop Consumer.seek() for apache/pulsar#16171
syhily
force-pushed
the
backport/release-1.14/FLINK-27399
branch
from
04dfdd4 to
f9666b8
Compare
tisonkun
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR for #19972.