-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-26607][python] There are multiple MAX_LONG_VALUE value errors in pyflink code #19089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103331d
to
146e605
Compare
dianfu
reviewed
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cun8cun8 Thanks for the contribution. Have left a minor comments. Besides, please also update other places, such as window_operator.py, window_aggregate_fast.pyx.
flink-python/pyflink/fn_execution/table/window_aggregate_slow.py
Outdated
Show resolved
Hide resolved
6c2a22d
to
d26c5ac
Compare
dianfu
pushed a commit
to dianfu/flink
that referenced
this pull request
Mar 17, 2022
…veral places This closes apache#19089.
dianfu
pushed a commit
that referenced
this pull request
Mar 17, 2022
…veral places This closes #19089.
JasonLeeCoding
pushed a commit
to JasonLeeCoding/flink
that referenced
this pull request
May 27, 2022
…veral places This closes apache#19089.
zstraw
pushed a commit
to zstraw/flink
that referenced
this pull request
Jul 4, 2022
…veral places This closes apache#19089.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is mainly to repair MAX_LONG_VALUE value
MAX_LONG_VALUE = sys.maxsize
maxsize attribute of the sys module fetches the largest value a variable of data type Py_ssize_t ** can store. It is the Python platform’s pointer that dictates the maximum size of lists and strings in Python. The size value returned by maxsize depends on the platform architecture:
32-bit: the value will be 2^31 – 1, i.e. 2147483647
64-bit: the value will be 2^63 – 1, i.e. 9223372036854775807
Brief change log
"""
A constant holding the maximum value a long can have, 2^63 – 1.
"""
MAX_LONG_VALUE = 0x7fffffffffffffff
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation