[FLINK-36645] [flink-autoscaler] Gracefully handle null execution pla… #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyfora
reviewed
Jan 10, 2025
| @@ -150,6 +151,11 @@ public static JobTopology fromJsonPlan( | |||
| ObjectNode plan = objectMapper.readValue(jsonPlan, ObjectNode.class); | |||
| ArrayNode nodes = (ArrayNode) plan.get("nodes"); | |||
|
|
|||
| if (nodes == null || nodes.isEmpty()) { | |||
| throw new NotReadyException( | |||
| new RuntimeException("No nodes found in the plan, job is not ready yet")); | |||
There was a problem hiding this comment.
Can we maybe add a new constructor to the NotReadyException so we don't need to wrap an unnecessary RuntimeException?
There was a problem hiding this comment.
Thanks for the quick review! Updated.
…n from autoscaler
sharath1709
force-pushed
the
FLINK-36645
branch
from
016b628 to
c697557
Compare
gyfora
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n from autoscaler
What is the purpose of the change
This pull request makes change to gracefully handle null execution plan returned from the Flink Rest API on autoscaler. This scenario can happen when a rescale operation is already in progress.
Brief change log
Verifying this change
This change added a unit test case to verify the ScalingMetricCollector throws NotReadyException when the execution plan is empty
Does this pull request potentially affect one of the following parts:
CustomResourceDescriptors: noDocumentation