[FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added #3230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PatrickRen , @morazow , CC |
yuxiqian
reviewed
Apr 17, 2024
...c-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java
Outdated
Show resolved
Hide resolved
loserwang1024
force-pushed
the
FLINK-35128
branch
from
59b1828 to
076eab9
Compare
morazow
suggested changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks @loserwang1024 for the PR!
I have minor question about choosing highWatermarks.
...c-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java
Show resolved
Hide resolved
morazow
approved these changes
Apr 18, 2024
…gelog offset after the new table added
…gelog offset after the new table added
loserwang1024
force-pushed
the
FLINK-35128
branch
from
076eab9 to
ca98c09
Compare
PatrickRen
approved these changes
Apr 25, 2024
loserwang1024
added a commit
to loserwang1024/flink-cdc-connectors
that referenced
this pull request
Apr 25, 2024
…gelog offset after the new table added (apache#3230) (cherry picked from commit bdca0e3)
wuzhenhua01
pushed a commit
to wuzhenhua01/flink-cdc-connectors
that referenced
this pull request
Aug 4, 2024
…gelog offset after the new table added (apache#3230)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…gelog offset after the new table added (apache#3230)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mysql cdc, re-calculate the starting binlog offset after the new table added in MySqlBinlogSplit#appendFinishedSplitInfos, while there lack of same action in StreamSplit#appendFinishedSplitInfos. This will cause data loss if any newly added table snapshot split's high_watermark is smaller.
Some unstable test problem occurs because of it.