Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34677][cdc] Synchronize Chinese documentations for Flink CDC #3169

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

PatrickRen
Copy link
Contributor

This pull request synchronized Chinese documentations for Flink CDC, to fully match English docs. Translations will be made by followup PRs.

@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 19, 2024
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRen for the contribution, I left two minor comments

@gtk96
Copy link
Contributor

gtk96 commented Mar 19, 2024

@PatrickRen Outstanding contribution, LGTM

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRen for the update and fix my typo, LGTM

@gtk96
Copy link
Contributor

gtk96 commented Mar 19, 2024

@PatrickRen
Copy link
Contributor Author

PatrickRen commented Mar 19, 2024

@leonardBang https://github.com/apache/flink-cdc/blob/master/docs/content/docs/get-started/quickstart/mysql-to-doris.md We also need a small patch here

@gtk96 It has been fixed in my followup commit 2646d2f

@PatrickRen PatrickRen merged commit 88c9cf2 into apache:master Mar 19, 2024
1 check passed
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants