Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-34732][cdc][ci] Add document dead link check for Flink CDC Documentation #3168

Merged
merged 3 commits into from
Mar 25, 2024
Merged

[FLINK-34732][cdc][ci] Add document dead link check for Flink CDC Documentation #3168

merged 3 commits into from
Mar 25, 2024

Conversation

GOODBOY008
Copy link
Member

…

@github-actions github-actions bot added the build label Mar 19, 2024
@GOODBOY008 GOODBOY008 marked this pull request as draft March 19, 2024 08:44
@github-actions github-actions bot added the docs Improvements or additions to documentation label Mar 19, 2024
@GOODBOY008 GOODBOY008 marked this pull request as ready for review March 19, 2024 10:08
@GOODBOY008 GOODBOY008 marked this pull request as draft March 19, 2024 11:37
@GOODBOY008 GOODBOY008 marked this pull request as ready for review March 19, 2024 11:41
@GOODBOY008
Copy link
Member Author

GOODBOY008 commented Mar 19, 2024 •
edited
Loading

@leonardBang @PatrickRen First ,I add this ci and quick fix some dead link. Some dead link maybe cannot fix currently.

The link like under:
[✖] https://repo1.maven.org/maven2/org/apache/flink/flink-cdc-pipeline-connector-mysql/3.0.0/flink-cdc-pipeline-connector-mysql-3.0.0.jar
[✖] https://repo1.maven.org/maven2/org/apache/flink/flink-cdc-pipeline-connector-starrocks/3.0.0/flink-cdc-pipeline-connector-starrocks-3.0.0.jar

@leonardBang leonardBang requested a review from PatrickRen March 19, 2024 13:29
@leonardBang
Copy link
Contributor

@leonardBang @PatrickRen First ,I add this ci and quick fix some dead link. Some dead link maybe cannot fix currently.

The link like under: [✖] https://repo1.maven.org/maven2/org/apache/flink/flink-cdc-pipeline-connector-mysql/3.0.0/flink-cdc-pipeline-connector-mysql-3.0.0.jar [✖] https://repo1.maven.org/maven2/org/apache/flink/flink-cdc-pipeline-connector-starrocks/3.0.0/flink-cdc-pipeline-connector-starrocks-3.0.0.jar

Could we use /com/ververica patch to make the url works?

PatrickRen
PatrickRen reviewed Mar 20, 2024
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 Thanks for the PR! I left some comments.

.dlc.json Outdated
Comment on lines 18 to 23
{
"pattern": "^https://img.shields.io"
},
{
"pattern": "^https://tokei.rs"
},
{
"pattern": "^https://json.org/"
},
{
"pattern": "^https://opencollective.com"
},
{
"pattern": "^https://twitter.com*"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have these links in the documentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will polish this config.

@GOODBOY008 GOODBOY008 requested a review from PatrickRen March 20, 2024 05:02
@GOODBOY008
Copy link
Member Author

@PatrickRen Rebased to master , PTAL

PatrickRen
PatrickRen approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GOODBOY008 Thanks for the update! LGTM

@PatrickRen PatrickRen merged commit 1c69a65 into apache:master Mar 25, 2024
15 checks passed
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
@GOODBOY008 @wuzhenhua01
[FLINK-34732][cdc][ci] Add document dead link check for Flink CDC Doc…
d93d98f 
…umentation (apache#3168)
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@GOODBOY008
[FLINK-34732][cdc][ci] Add document dead link check for Flink CDC Doc…
e007c69 
…umentation (apache#3168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickRen PatrickRen PatrickRen approved these changes

Assignees
No one assigned
Labels
build docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GOODBOY008 @leonardBang @PatrickRen