Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-34577] Add IssueNavigationLink for IDEA git log #3096

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

GOODBOY008
Copy link
Member

@GOODBOY008 GOODBOY008 commented Mar 5, 2024

Add IssueNavigationLink for IDEA git log

@github-actions github-actions bot added the build label Mar 5, 2024
@GOODBOY008
Copy link
Member Author

@Jiabao-Sun PTAL

@GOODBOY008 GOODBOY008 requested a review from Jiabao-Sun March 5, 2024 08:41
Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GOODBOY008 for this contribution.
LGTM.

@GOODBOY008 GOODBOY008 force-pushed the feature/FLINK-34577 branch from 59cee07 to aa8f9b8 Compare March 5, 2024 08:48
pom.xml Outdated
@@ -288,6 +288,9 @@ under the License.
</licenseFamily>
</licenseFamilies>
<excludes>
<!-- IDE files. -->
<exclude>**/*.iml</exclude>
<exclude>**/.idea/**</exclude>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they necessary? IMO these two patterns should be redundant while there is **/.*/** below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,not need to add exclude.

@GOODBOY008 GOODBOY008 force-pushed the feature/FLINK-34577 branch from aa8f9b8 to 266f8fd Compare March 5, 2024 09:01
@GOODBOY008 GOODBOY008 force-pushed the feature/FLINK-34577 branch from 266f8fd to 487b325 Compare March 5, 2024 09:06
@GOODBOY008 GOODBOY008 requested a review from whhe March 5, 2024 09:12
@Jiabao-Sun Jiabao-Sun merged commit 96888b2 into apache:master Mar 5, 2024
13 checks passed
aiwenmo pushed a commit to aiwenmo/flink-cdc-connectors that referenced this pull request Mar 6, 2024
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
wuzhenhua01 pushed a commit to wuzhenhua01/flink-cdc-connectors that referenced this pull request Aug 4, 2024
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants