-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34577] Add IssueNavigationLink for IDEA git log #3096
Conversation
@Jiabao-Sun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GOODBOY008 for this contribution.
LGTM.
59cee07
to
aa8f9b8
Compare
pom.xml
Outdated
@@ -288,6 +288,9 @@ under the License. | |||
</licenseFamily> | |||
</licenseFamilies> | |||
<excludes> | |||
<!-- IDE files. --> | |||
<exclude>**/*.iml</exclude> | |||
<exclude>**/.idea/**</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they necessary? IMO these two patterns should be redundant while there is **/.*/**
below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,not need to add exclude.
aa8f9b8
to
266f8fd
Compare
266f8fd
to
487b325
Compare
Add IssueNavigationLink for IDEA git log