-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-34180] Migrate doc website from ververica to flink #3028
Conversation
beb598a
to
e669110
Compare
ae114ae
to
c695eb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GOODBOY008 Thanks for the awesome work! I left one comment.
.dlc.json
Outdated
@@ -0,0 +1,32 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file I would like to check dead link in doc,but curretly do not active
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about we introduce this file after we enable the dead link check in the future? I'm not sure links in this file currently are related to Flink CDC's doc.
d1f2ce7
to
0fc2df7
Compare
6331461
to
5b2f502
Compare
5b2f502
to
7a357f9
Compare
cd4e015
to
f76185d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GOODBOY008 Thanks for the PR! LGTM overall. Let's merge first and see if the doc can be built successfully.
[FLINK-34180] Migrate doc website from ververica to flink.