-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix][cdc-connector][mysql] skip SchemaChangeEvents that were not included in capturedTableFilter. #2986
[hotfix][cdc-connector][mysql] skip SchemaChangeEvents that were not included in capturedTableFilter. #2986
Conversation
@ruanhang1993 @Jiabao-Sun PTAL. |
|
…included in capturedTableFilter.
a4e1539
to
d526bd1
Compare
@leonardBang CC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lvyanquan for the fix, LGTM
…included in capturedTableFilter (apache#2986) This closes apache#2981
@joyCurry30 @leonardBang Logically, it is considered a bug when I have to read all tables in the schema, and the first execution of "alter table sql" is not triggered. However, since TableDiscoveryUtils loads all tables, it works. But in a SaaS environment, with so many tables(five hundred thousand, a tenant has their own tables), this will cause issues. Because we can't load all tables when have to discover the new Table with query sql by "show create sql " for every table. |
In the design of TiDB, I find that they take into account the scenario of having a large number of tables in a SaaS environment. Therefore, special attention is given to the performance of DDL operations in such contexts. |
…included in capturedTableFilter (apache#2986) This closes apache#2981
This closes #2981.