Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][postgres] Apply DBZ-5398 postgres connector fix #2842

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

loserwang1024
Copy link
Contributor

Fix #2710, just CP DBZ-5398 in Flink CDC. It resolve the problem of a table without primary key but a functional unique index , such as create unique index test_tbl_idx on test_table(id, COALESCE(char_c, ''::text));.

For Increment snapshot mode, In the snapshot phase , table without primary key is not allowed, Thus, when scan.incremental.snapshot.enabled = true, only use 'latest-offset' startup mode to test.

@loserwang1024
Copy link
Contributor Author

CC, @sandeepkdeva, @ruanhang1993

@sandeepkdeva
Copy link

lgtm.. thanks for the PR

@sandeepkdeva
Copy link

Hi @loserwang1024 , any update on when this will be merged? Thanks!

@loserwang1024
Copy link
Contributor Author

Hi @loserwang1024 , any update on when this will be merged? Thanks!
@leonardBang , @ruanhang1993 , CC

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loserwang1024 for the contribution, LGTM. could you rebase to the latest master?

@loserwang1024
Copy link
Contributor Author

@leonardBang , Done it.

@leonardBang leonardBang merged commit e3d6c7e into apache:master Jan 18, 2024
17 checks passed
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Apply DBZ-5398 postgres connector fix
3 participants