[ISSUE #4723] Fix get meta from nacos return 403 #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
approved these changes
Jan 5, 2024
pandaapo
reviewed
Jan 5, 2024
| @@ -315,6 +315,8 @@ private Map<String, String> getResultFromNacos(int pageNo, int pageSize, String | |||
| } | |||
| URI uri = uriBuilder.build(); | |||
| HttpGet httpGet = new HttpGet(uri); | |||
| httpGet.setHeader("username",username); | |||
| httpGet.setHeader("password",password); | |||
There was a problem hiding this comment.
Can NacosConstant.USERNAME and NacosConstant.PASSWORD be used to replace them?
pandaapo
approved these changes
Jan 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4724 +/- ##
============================================
- Coverage 17.44% 17.44% -0.01%
Complexity 1768 1768
============================================
Files 797 797
Lines 29845 29847 +2
Branches 2563 2563
============================================
Hits 5206 5206
- Misses 24159 24161 +2
Partials 480 480 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4723.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation