Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Auto approve when dependabot's branch is changed by someone else #144

Closed
3 tasks done
Pil0tXia opened this issue May 27, 2024 · 0 comments · Fixed by #145
Closed
3 tasks done

[Enhancement] Auto approve when dependabot's branch is changed by someone else #144

Pil0tXia opened this issue May 27, 2024 · 0 comments · Fixed by #145
Labels
enhancement New feature or request

Comments

@Pil0tXia
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Currently, this workflow is only executed when the actor is dependabot. When I find that dependabot's modification of a dependency does not meet my needs, I will make a modification to the branch of dependabot. However, after the modification, this workflow will be skipped. i want this workflow to still execute after I commit to the branch of dependabot.

Describe the solution you'd like

Change the execution condition to PR's branch is dependabot's branch or PR's author is dependabot.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@Pil0tXia Pil0tXia added the enhancement New feature or request label May 27, 2024
@Pil0tXia Pil0tXia mentioned this issue May 27, 2024
Merged
Pil0tXia added a commit that referenced this issue May 27, 2024
@Pil0tXia
[ISSUE #144] Auto approve when dependabot's branch is changed by some…
8b0e4e5 
…one else (#145)

* a more standard way to prevent creating dependabot PRs

* approve if the PR author is dependabot

* approve if the PR branch belongs to dependabot

* Revert "approve if the PR branch belongs to dependabot"

This reverts commit aabcdc4.
@Pil0tXia Pil0tXia mentioned this issue May 27, 2024
Closed
3 tasks
SLSJL pushed a commit to SLSJL/eventmesh-dashboard that referenced this issue Jun 3, 2024
Merge branch 'main' into dev
500b5ba 
* main: (32 commits)
  [ISSUE apache#144] Auto approve when dependabot's branch is changed by someone else (apache#145)
  chore(deps): bump gradle/gradle-build-action from 2 to 3 (apache#140)
  chore(deps): bump actions/setup-java from 3 to 4 (apache#139)
  [ISSUE apache#134] Deploy Meta, Event Store and Runtime test environments in CI (apache#135)
  [ISSUE apache#63] Function Manager and Health Service update (apache#98)
  chore(deps): bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (apache#124)
  chore(deps): bump com.alibaba.fastjson2:fastjson2 from 2.0.40 to 2.0.49 (apache#125)
  chore(deps): bump org.springdoc:springdoc-openapi-ui from 1.7.0 to 1.8.0 (apache#127)
  [ISSUE apache#132] Make Maven Wrapper executable (apache#133)
  [ISSUE apache#130] Auto-approve Dependabot PR only and Disable PR up-to-date check (apache#131)
  [ISSUE apache#128] Use GitHub CLI `comment` to auto-merge a Dependabot PR (apache#129)
  [ISSUE apache#122] Enable auto-merge workflow of Dependabot (apache#123)
  chore(deps): bump webpack-dev-middleware in /eventmesh-dashboard-view (apache#117)
  Add SDKManager JavaDoc and some code optimisation (apache#121)
  [ISSUE apache#119] Introduce dependencies for a unified return front-end format (apache#120)
  chore(deps): bump spring-boot.version from 2.7.6 to 2.7.18 (apache#112)
  chore(deps): bump org.apache.rocketmq:rocketmq-client (apache#115)
  chore(deps): bump org.apache.maven.plugins:maven-surefire-plugin (apache#111)
  chore(deps): bump org.apache.maven.plugins:maven-compiler-plugin (apache#114)
  chore(deps): bump io.etcd:jetcd-core from 0.7.5 to 0.7.7 (apache#113)
  ...

# Conflicts:
#	eventmesh-dashboard-view/src/assets/icons/index.ts
#	eventmesh-dashboard-view/src/routes/RootLayout.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/Topic.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/stats/Stats.tsx
#	eventmesh-dashboard-view/src/routes/cluster/topic/stats/TopicCount.tsx
#	eventmesh-dashboard-view/src/routes/navigation/Navigation.tsx
#	eventmesh-dashboard-view/src/routes/topic/topic-list/TopicList.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Pil0tXia