fix(boxplot) correctly handle series.encode with category axis #20324
Conversation
echarts-bot
bot
added
PR: awaiting review
PR: doc unchanged
PR: first-time contributor
labels
|
Thanks for your contribution! |
jonoshearman
changed the title
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20324@399fb2f |
src/chart/helper/whiskerBoxCommon.ts
Outdated
| */ | ||
| _hasEncodeRule(key: string) { | ||
| const encodeRules = this.getEncode(); | ||
| if(encodeRules?.data?.has(key)) |
There was a problem hiding this comment.
We avoid using ?. under compatible considerations. Please use encodeRules && encodeRules.data && encodeRules.data.has(key) instead.
There was a problem hiding this comment.
Thanks for the review @Ovilia
Changes pushed.
jonoshearman
force-pushed
the
fix-boxplot-category-encode-20319
branch
from
bc5c888
to
41ff0b0
Compare
src/chart/helper/whiskerBoxCommon.ts
Outdated
| _hasEncodeRule(key: string) { | ||
| const encodeRules = this.getEncode(); | ||
| if (encodeRules && encodeRules.data && encodeRules.data.has(key)) { | ||
| return encodeRules.data.get(key) !== null; |
There was a problem hiding this comment.
Using != instead of !== please.
There was a problem hiding this comment.
Thanks, changes pushed
|
Please don't use forced push because it would be hard to track the changes of previous reviews. |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
|
We sincerely appreciate your valuable contributions! We are currently running a special promotion for users who submit a Pull Request between September 25, 2024, and December 31, 2024. Eligible participants will receive a two-year enterprise membership to Baidu Comate, valued at 2000 RMB (approximately 285 USD). To learn more about this product, please visit https://comate.baidu.com/. If you are interested in this offer, kindly send an email with the link to your Pull Request along with your Comate username and email address to ovilia@apache.org to claim your membership. Thank you once again for your support! |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes issue with series.encode for boxplot when category axis is used.
Fixed issues
#20319
Details
Before: What was the problem?
When a category axis is used for a boxplot series, an ordinalValue is always inserted to the series.data which breaks any encoding rules. if the category axis does not set it's own data then the axis labels will be the integer ordinalValue.
After: How does it behave after the fixing?
Now if an encode rule is applied for the associated axis (x/y) then the ordinalValue is not inserted and the encoding rules work as expected.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
test/boxplot-category.html added to show visual example.
Others
Merging options
Other information