Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roam): fix RoamControllerHost importing path #20313

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix(roam): fix RoamControllerHost importing path #20313

merged 2 commits into from
Sep 2, 2024

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Sep 2, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

f7e61f2 moves RoamController to a different file so the importing path changes. However, by the time #18304 was merged, the above change was only in the next/v6 release so that the importing path had an error on these branches.

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

Copy link

echarts-bot bot commented Sep 2, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia added this to the 6.0.0 milestone Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20313@ccdc4b9

@Ovilia Ovilia merged commit d2eba0f into v6 Sep 2, 2024
2 checks passed
Copy link

echarts-bot bot commented Sep 2, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix-roam branch September 2, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant