-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dataZoom): change moveHandler cursor icon to move #20304
Conversation
fix(gauge): fix z2 is negative when maxVal is negative
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old one was correct because this is the cursor for single directional (vertical or horizontal). 'move'
means it can move in both directions, but in fact it can only move in one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you made a great point, especially with the research of other apps. But this may cause break change so I'd like to include it in the next major release v6.0.0. It's expected to be released earlier next year.
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20304@7fe6fa2 |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Change cursor icon to more intuitive 'move', for dataZoom slider moveHandle
Fixed issues
Details
Before: What was the problem?
The Move/Drag icon is not intuitive, and it makes it difficult to know whether you're busy resizing or dragging, when the mouse is nearby the edge.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information