-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aria): allows excluding data in aria-label #20218
Conversation
Thanks for your contribution! Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
src/util/types.ts
Outdated
@@ -1733,7 +1733,8 @@ export interface AriaLabelOption { | |||
separator?: { | |||
middle?: string; | |||
end?: string; | |||
} | |||
}, | |||
excludeDataId?: number[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename excludeDataId
into excludeDimensionId
. Thanks!
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20218@b1a2374 |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Thanks for your contribution! Please also make a pull request to echarts-doc, adding the new option in the document. You should commit the changes in the |
Brief Information
This pull request is in the type of:
What does this PR do?
Allows excluding data in aria-label
Fixed issues
Details
Before: What was the problem?
All data was present in the aria-label. My use case was for a map chart, where the coordinates should be excluded.
After: How does it behave after the fixing?
Add column indexes to be excluded to aria.data.excludeDataId and they will not appear in the data in aria.label.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information