Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(treemap): add custom cursor properties for treemap #20113

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

adaelixir
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Adding custom cursor properties for Treemap

Fixed issues

Details

Before: What was the problem?

In treemap, there is no way to customize the cursor style through cursor, and it can only default to "pointer"

After: How does it behave after the fixing?

Users can set the cursor style in option like other series graph

series: [
 {
    name: 'TreeMap Cursor',
    type: 'treemap',
    label: ... ,
    breadcrumb: ... ,
    levels: ... ,
    cursor:'crosshair',  // it should be able to set crosshair for treemap
    data: 
  }
]
image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Jul 4, 2024
Copy link

echarts-bot bot commented Jul 4, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@adaelixir adaelixir marked this pull request as draft July 4, 2024 14:17
@adaelixir adaelixir marked this pull request as ready for review July 4, 2024 14:59
src/chart/treemap/TreemapSeries.ts Outdated Show resolved Hide resolved
src/chart/treemap/TreemapSeries.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jul 26, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20113@17c680b

@Ovilia Ovilia merged commit ce500cf into apache:master Jul 29, 2024
2 checks passed
Copy link

echarts-bot bot commented Jul 29, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.2 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants