fix(candlestick): add back missing support for non-normal states since v5.0.0 #20105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20105@89a15af |
echarts-bot
bot
added
PR: awaiting doc
|
Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the |
plainheart
added a commit
to apache/echarts-doc
that referenced
this pull request
Jul 2, 2024
echarts-bot
bot
added
PR: doc ready
and removed
PR: awaiting doc
8 tasks
linghaoSu
approved these changes
Jul 17, 2024
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
The previous commit 31f9a59 removed support for emphasis state unexpectedly in v5 refactor. This PR is to add it back while adding support for (blur / select).
Fixed issues
N.A.
Comparison
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to the second case in
test/candlestick-case.html.Others
Merging options
Other information