Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): fix clipping in custom series off by pixel #20043

Merged

Conversation

fandi-1205
Copy link
Contributor

@fandi-1205 fandi-1205 commented Jun 18, 2024

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

#19993 Clipping in custom series off by 1 pixel

Fixed issues

Details

Before: What was the problem?

There is a boundary overflow issue when creating a clipping path in the custom series.

image

After: How does it behave after the fixing?

The overflow occurs because the clipping path is widened to fully display the first and last ends of the line chart. In the source code, the logic is to first obtain the width of the polyline, and adjust the clipping path based on this width. After consulting the documentation, I found that under custom If you do not set the lineStyle attribute, you must ensure that the chart without the lineStyle attribute is trimmed strictly according to the grid. Then you only need to set the chart without the lineStyle attribute not to expand.

image

This change will have an impact on charts that do not have the lineStyle.width attribute but use a clipping path, but the impact is reasonable and acceptable, such as the following case

image
image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Jun 18, 2024
Copy link

echarts-bot bot commented Jun 18, 2024

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

It seems that the expected clipped area of the custom series on grid is not correct yet.

With

axisLine: {
  lineStyle: {
    width: 50,
    color: 'rgba(255, 0, 0, 0.2)'
  }
}

we can see that current clipped area excludes half axisLine width, which is not expected because this makes api.coord(0, 0) not at the position of the origin of the axes.

So axisLine width should probably not considered in this case.

@echarts-bot echarts-bot bot added PR: awaiting review PR: doc unchanged and removed PR: revision needed PR: awaiting doc Document changes is required for this PR. labels Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20043@58cb454

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with visual testing and some cases failed with bar series and are considered to be as expected.

@Ovilia Ovilia merged commit 369cb03 into apache:master Jun 28, 2024
2 checks passed
Copy link

echarts-bot bot commented Jun 28, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.2 milestone Jun 28, 2024
@plainheart plainheart changed the title fix: clipping in custom series off by pixel#19993 fix(grid): fix clipping in custom series off by pixel Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants