Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): Use actual area measure instead of radius in Rose Chart #15674 #18978

Closed
wants to merge 5 commits into from

Commits on Aug 9, 2023

  1. fix(pie): Use actual area measure instead of radius in Rose Chart apa…

    …che#15674
    
    This pull request addresses the issue mentioned in apache#15674 by fixing the calculation of the slice radius in the Rose Chart. Currently, the radius of the sectors in the chart is mapped to the data, which can be misleading and result in disproportionate representation of the values.
    The proposed solution suggests calculating the slice radius using the square root of the value, rather than the value itself. This adjustment will ensure that the areas of the slices accurately reflect the data, providing a more consistent and visually accurate representation.
    By implementing this change, the resulting rendering of the Rose Chart will accurately represent the differences in data points, providing a more informative and visually appealing visualization.
    This pull request aims to improve the Rose Chart functionality and enhance the overall user experience.
    lulu0119 committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b6930ed View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    5c0fecc View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    9412c98 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Configuration menu
    Copy the full SHA
    df2d76a View commit details
    Browse the repository at this point in the history
  2. feat(pie): Add new roseType value 'scaledArea' and corresponding test…

    … cases apache#15674
    
    This commit adds a new value 'scaledArea' to the roseType option in rose chart. When set to 'scaledArea', the radius is calculated based on the square root, and the ratio of the actual value is proportional to the ratio of the area occupied by different items. Additionally, new test cases have been added to demonstrate the effects of different roseType values.
    
    My testing shows that when the value is negative, the pie chart will lack that specific item, but it is unclear how the code handles it.
    lulu0119 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    20b51db View commit details
    Browse the repository at this point in the history