Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(line): show single symbol when pre and next data is null #18815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

linghaoSu
Copy link
Member

@linghaoSu linghaoSu commented Jun 27, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

when showSymbol is 'single', add symbol when pre data and next data is null

Fixed issues

Details

Before: What was the problem?

when showSymbol is false, when pre and next is null, the data between would not show

normal

image

hover:
image

After: How does it behave after the fixing?

will show single symbol when pre and next data is null, unless connectNulls is true

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jun 27, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 29, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18815@047e0a8

@linghaoSu
Copy link
Member Author

linghaoSu commented Jul 14, 2023

demo

@FanLu1994
Copy link

not working for xAxis (type:time)
demo : demo

@linghaoSu linghaoSu force-pushed the feat/line-series-single-point branch from b668fcb to bacb997 Compare August 8, 2023 15:02
@linghaoSu
Copy link
Member Author

linghaoSu commented Aug 8, 2023

fix not work for time series

demo : demo

@echarts-bot
Copy link

echarts-bot bot commented Aug 11, 2023

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@linghaoSu linghaoSu force-pushed the feat/line-series-single-point branch 2 times, most recently from 3a3a880 to 475b47d Compare July 8, 2024 14:16
@mahoushoujoarale
Copy link

this would be helpful @Ovilia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting doc Document changes is required for this PR. PR: awaiting review size/M
Projects
None yet
3 participants