Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Axis): axisTick.interval work correct #18037

Closed
wants to merge 1 commit into from

Conversation

erweixin
Copy link

@erweixin erweixin commented Dec 8, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

axisTick.interval work correct.
onBand mode, we has one more tick. and this tick should aeffected by interval.

Fixed issues

#17967

Details

Before: What was the problem?

tick always at axisExtent[0] when interval funciton return array of length one .

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 8, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@erweixin erweixin changed the title [WIP] fix(Axis): axisTick.interval work correct fix(Axis): axisTick.interval work correct Dec 8, 2022
@Ovilia
Copy link
Contributor

Ovilia commented Dec 9, 2022

Thanks for your contribution! Please check how to test and do the Run visual test: part. You probably also need to add a test file. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants