Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] (pie): incorrect response area of pie piece when applied selectedOffset #18412

Closed
100pah opened this issue Mar 23, 2023 · 1 comment · Fixed by ecomfe/zrender#1011
Closed

[Bug] (pie): incorrect response area of pie piece when applied selectedOffset #18412

100pah opened this issue Mar 23, 2023 · 1 comment · Fixed by ecomfe/zrender#1011
Labels
bug en This issue is in English topic: pie
Milestone
5.4.3

Comments

@100pah
Copy link
Member

100pah commented Mar 23, 2023 •
edited by plainheart
Loading

Version

5.0.0

Link to Minimal Reproduction

Demo for Reproduction

Steps to Reproduce

firstly, click one section:

image

Then click the section again to make it return the original position:

image

At present the clickable area is not returned, but still:

image

Then the clickable area is not correct for ever.

Then I run the visual test, but the visual test about pie all passed, not cover this case.

Current Behavior

Expected Behavior

click area should be correct.

Environment

- OS:
- Browser:
- Framework:

Any additional comments?

No response
@100pah 100pah added the bug label Mar 23, 2023
@100pah 100pah added this to the 5.5.0 milestone Mar 23, 2023
@plainheart plainheart added en This issue is in English topic: pie labels Mar 23, 2023
@Ovilia Ovilia changed the title [Bug] [Bug] (pie): selected pie piece cannot go back Mar 23, 2023
@plainheart plainheart changed the title [Bug] (pie): selected pie piece cannot go back [Bug] (pie): incorrect response area of pie piece when applied selectedOffset Mar 23, 2023
@LaxusT
Copy link

LaxusT commented Mar 23, 2023 •
edited
Loading

You can circumvent this issue through animation attributes.

My Demo

plainheart added a commit that referenced this issue May 14, 2023
@plainheart
test(pie): add a test case to cover #18412
bb403c1
This was referenced May 14, 2023
Merged
Merged
plainheart added a commit that referenced this issue May 15, 2023
@plainheart
Merge pull request #18625 from apache/test/pie-selectedOffset
38d0265 
test(pie): add a test case to cover #18412
@plainheart plainheart modified the milestones: 5.5.0, 5.4.3 Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug en This issue is in English topic: pie
Projects
None yet
Milestone
5.4.3
Development

Successfully merging a pull request may close this issue.

fix(transform): fix invTransform may not be reset when updating transform ecomfe/zrender
3 participants
@100pah @LaxusT @plainheart