Merge pull request #20300 from apache/fix-pictorial-zero

fix(pictorialBar): symbol should not flip with zero data
apache · Sep 30, 2024 · 869ec5e · 869ec5e
2 parents bb12cee + 65ac3c3
commit 869ec5e
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 1 deletion.
diff --git a/src/chart/bar/PictorialBarView.ts b/src/chart/bar/PictorialBarView.ts
@@ -341,7 +341,7 @@ function prepareBarLength(
 
     // if 'pxSign' means sign of pixel,  it can't be zero, or symbolScale will be zero
     // and when borderWidth be settled, the actual linewidth will be NaN
-    outputSymbolMeta.pxSign = boundingLength > 0 ? 1 : -1;
+    outputSymbolMeta.pxSign = boundingLength >= 0 ? 1 : -1;
 }
 
 function convertToCoordOnAxis(axis: Axis2D, value: number) {

diff --git a/test/pictorial-zero-value.html b/test/pictorial-zero-value.html