Merge pull request #19892 from OverflowCat/master

fix(aria): avoid throwing error in SSR mode (#19191)
apache · May 6, 2024 · 832cc51 · 832cc51
2 parents bdc5d4f + 872ac99
commit 832cc51
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/visual/aria.ts b/src/visual/aria.ts
@@ -139,6 +139,12 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
     }
 
     function setLabel() {
+        const dom = api.getZr().dom;
+        // TODO: support for SSR
+        if (!dom) {
+            return;
+        }
+
         const labelLocale = ecModel.getLocaleModel().get('aria');
         const labelModel = ariaModel.getModel('label');
         labelModel.option = zrUtil.defaults(labelModel.option, labelLocale);
@@ -147,7 +153,6 @@ export default function ariaVisual(ecModel: GlobalModel, api: ExtensionAPI) {
             return;
         }
 
-        const dom = api.getZr().dom;
         if (labelModel.get('description')) {
             dom.setAttribute('aria-label', labelModel.get('description'));
             return;

diff --git a/test/node/ssr.js b/test/node/ssr.js