Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add router fail fast option #9388

Merged
merged 1 commit into from
Dec 12, 2021
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

Merging #9388 (dfa5d58) into 3.0 (78fd454) will decrease coverage by 0.02%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #9388      +/-   ##
============================================
- Coverage     65.28%   65.26%   -0.03%     
- Complexity      342      343       +1     
============================================
  Files          1202     1202              
  Lines         51878    51939      +61     
  Branches       7729     7736       +7     
============================================
+ Hits          33870    33898      +28     
- Misses        14391    14419      +28     
- Partials       3617     3622       +5     
Impacted Files Coverage Δ
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 69.40% <50.00%> (-0.30%) ⬇️
...e/dubbo/registry/integration/DynamicDirectory.java 65.13% <80.00%> (-0.29%) ⬇️
...bbo/rpc/proxy/javassist/JavassistProxyFactory.java 26.92% <0.00%> (-73.08%) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 59.37% <0.00%> (-14.07%) ⬇️
.../org/apache/dubbo/rpc/protocol/tri/WriteQueue.java 87.50% <0.00%> (-6.25%) ⬇️
...bbo/common/resource/GlobalResourcesRepository.java 70.90% <0.00%> (-1.82%) ⬇️
...java/org/apache/dubbo/common/utils/ClassUtils.java 79.06% <0.00%> (-1.82%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 66.37% <0.00%> (-1.77%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 75.17% <0.00%> (-1.42%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.03% <0.00%> (-0.33%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78fd454...dfa5d58. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 312dd2b into apache:3.0 Dec 12, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request Dec 21, 2022
AlbumenJ added a commit that referenced this pull request Dec 21, 2022
* Add router fail fast option (Backport #9388)

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants